Support complex arguments and limit number of positional arguments in xmlchange #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Replaces PR #343 |
Merged
wilke
changed the title
rljacob
changed the title
|
This still doesn't work |
rljacob
changed the title
|
The comma syntax is a new feature, I suggest closing this pull request and branch and opening a new issue? |
|
Yes. That is the "git way". |
|
okay fine - please resolve conflicts and merge, I will open an issue on the syntax error. |
Conflicts: scripts/Tools/xmlchange
|
Andreas, Jim was supposed to integrate this. No one should merge their own PRs to master. |
|
Nevermind. I see Jim told you to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limiting the number of positional command line arguments to 1 or 0.
Implicit provided argument is in the form of key=value.
Supporting complex arguments. The value in key=value can contain equal signs too.
Test suite:
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]
Fixes #323
Fixes #385
Avoids problems reported in #359 and #364
Connects to #359
Connects to #364
User interface changes?:
Code review: