-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More mira port #258
More mira port #258
Conversation
I am going to try testing this change using CIME_MODEL=cesm with the following case,
|
This PR also seems to have changes for other (not mira) machines. Is that intentional? |
@@ -142,21 +143,21 @@ | |||
</batch_system> | |||
|
|||
<!-- babbage is PBS --> | |||
<batch_system MACH="babbage" version="x.y"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated some config_batch.xml for machines that are rarely used or tested.
@jedwards4b : I updated the PR message with the information (changes not related to mira) above. Please go through it and feel free to update/modify the new comments. |
looks good, thank you |
I have submitted a job on Cetus for CIME_MODEL=cesm (create/setup/build/submit succeeds). The ./create_newcase command failed with CIME_MODEL=acme . This will need to be pursued as part of Issue #245 . The output from create_newcase (CIME_MODEL=acme) is shown below,
|
The PR has been updated with a fix for the above, please try again. |
Got the following error with CIME_MODEL=cesm (in the job error output),
@jedwards4b : Can you build and run any case on Mira/Cetus with CIME_MODEL=cesm ? I could try the case that you are using in your tests to see if the fix works. |
17b8a33
to
037d253
Compare
I have submitted a job (case creates+builds+submits correctly) on Mira for CIME_MODEL=cesm . |
I'm sorry I thought that it would work for acme - what problem are you seeing? |
No worries, I will start looking at the issues (the first one was due to missing PES_PER_NODE tag). Let me try to get it working and will let you know the details. |
I got the following error at runtime (CIME_MODEL=cesm) after merging the branch locally to master,
Will try it with master and see how it goes. |
The "not able to fully resolve" is not an error, it is expected on mira because of the LOCARGS flag. |
The error message above is with CIME_MODEL=cesm, and I only have JOBID.{output|error|cobaltlog} in the case directory |
the acme.log file will be in the run directory |
Looks like an issue in my environment, although I had set CIME_MODEL=cesm while building the model my shell startup files had CIME_MODEL=acme. After changing it to CIME_MODEL=cesm, the job ran successfully. |
Did this also fix #253 ? |
I believe so |
Several changes to get Mira working was added in 1f9f0b3 . However some build and runtime issues remained with CIME_MODEL=acme . This commit adds the remaining fixes required to get the code working on Mira for CIME_MODEL=acme. * Fixed the batch submit command * Added the PES_PER_NODE tag * Fixed the name of the default project (now called HiRes_EarthSys_2) * Modified the locargs argument for runjob (--block) These fixes are already present in cesm (CIME_MODEL=cesm). Also see Issue #245 and PR #258
This simply uses github's suggested code of conduct, which looks good to me. Fixes ESMCI#258
This change gets a basic case setup working on mira again. However the workflow - running st_archive and then resubmitting does not yet work. This means that ERR and ERI tests will not work. mpi-serial is also not supported on this platform so most of the scripts_regression_tests will also fail.
Also including updates (machine file updates) for machines rarely used/tested - Updating batch system type for babbage, brutus, eos, erebus, hera, pleiades-wes, sierra, titan.
Also build output is now logged, streaming it to a file, instead of buffering it in memory.
Test suite:
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]
Closes #245
User interface changes?:
Code review: jayesh