Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty proxy tag from anlworkstation again #1989

Merged
merged 1 commit into from
Oct 24, 2017

Conversation

dqwu
Copy link
Contributor

@dqwu dqwu commented Oct 24, 2017

This is a regression: the empty proxy tag for anlworkstation was removed
by PR #1689, but it was added back by PR #1970 during the merge.

Test suite: scripts_regression_tests
Test baseline:
Test namelist changes:
Test status:

Fixes #1534

User interface changes?: N

Update gh-pages html (Y/N)?: N

Code review: @jgfouca

@dqwu dqwu requested a review from jgfouca October 24, 2017 21:23
@dqwu dqwu changed the title empty proxy tag in machines file invalid, removed from anlworkstation Remove empty proxy tag from anlworkstation again Oct 24, 2017
@jgfouca
Copy link
Contributor

jgfouca commented Oct 24, 2017

It looks like this has finally been removed on the ACME side too, so this shouldn't come back again.

@jgfouca jgfouca merged commit a8cd748 into master Oct 24, 2017
@jgfouca jgfouca deleted the dqwu/anlworkstation-remove-proxy-tag branch October 24, 2017 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants