Add support for selecting different driver. #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Add --driver flag to create_newcase 2) Add support for _V$driver_ test opt to create_test 3) Remove places where mct was hardcoded 4) Add support for driver selection to case.configure, case.create Lots of XML changes will be needed in the models to truly support different drivers. This PR just removes the core infrastructure as blocker for this effort.
jedwards4b
approved these changes
Oct 24, 2017
|
What are the XML changes needed? Does this supply all the functionality @mvertens implemented in her NUOPC branch? |
|
I'm not familiar with her branch. @mvertens , can you chime in here? |
|
@jgfouca - the forked noupc repository is https://github.com/apcraig/cime and the branch is nuopcB. This branch now also has the -Vnuopc as an option and its up to date with esmci/master hash 0e5cee1 - which is a few hashes after cime5.4.0-alpha.04. |
|
@jedwards4b yeah, that's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of XML changes will be needed in the models to truly support
different drivers. This PR just removes the core infrastructure as
blocker for this effort.
Test suite: scripts_regression_tests
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #1781
User interface changes?: Yes, --driver added to create_newcase, new _V$driver testopt
Update gh-pages html (Y/N)?: N
Code review: @jedwards4b @mvertens