Refactor how spare nodes get computed. #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prior implementation was a bit too simple. Always giving the user 10 percent of nodes as spare nodes was way overkill for large jobs. The new implementation maxes out the number of spare nodes at 10. We also add a new variable to allow the user to pick the exact number of spare nodes that they want.
amametjanov
approved these changes
Aug 15, 2017
jedwards4b
approved these changes
Aug 15, 2017
|
Going to go ahead and merge. @vanroekel can ping me anytime to tweak the implementation. |
jgfouca
added a commit
that referenced
this pull request
Oct 17, 2017
Disable performance archiving if timing dir. cannot be written into Currently, if the directory where performance data and associated provenance data are to be saved already exists or cannot be created or populated, then the job aborts. This change allows the job to proceed, simply disabling the performance data archiving. This will allow the use of default locations for saving the performance data that are legal for users in the E3SM project but which will not be legal for E3SM users who are not part of the project. These external users can define alternative locations in their job cases. BFB Fixes #1816 * origin/worleyph/cime/e3sm_perf_archiving: Modifying warning message when archiving of timing data is disabled (4) Modifying warning message when archiving of timing data is disabled (3) Modifying warning message when archiving of timing data is disabled (2) Modifying warning message when archiving of timing data is disabled Make similar changes in _save_postrun_timing_acme function Disable performance archiving if timing dir. can not be written into
jgfouca
added a commit
that referenced
this pull request
Feb 23, 2018
Disable performance archiving if timing dir. cannot be written into Currently, if the directory where performance data and associated provenance data are to be saved already exists or cannot be created or populated, then the job aborts. This change allows the job to proceed, simply disabling the performance data archiving. This will allow the use of default locations for saving the performance data that are legal for users in the E3SM project but which will not be legal for E3SM users who are not part of the project. These external users can define alternative locations in their job cases. BFB Fixes #1816 * origin/worleyph/cime/e3sm_perf_archiving: Modifying warning message when archiving of timing data is disabled (4) Modifying warning message when archiving of timing data is disabled (3) Modifying warning message when archiving of timing data is disabled (2) Modifying warning message when archiving of timing data is disabled Make similar changes in _save_postrun_timing_acme function Disable performance archiving if timing dir. can not be written into
jgfouca
added a commit
that referenced
this pull request
Mar 13, 2018
Disable performance archiving if timing dir. cannot be written into Currently, if the directory where performance data and associated provenance data are to be saved already exists or cannot be created or populated, then the job aborts. This change allows the job to proceed, simply disabling the performance data archiving. This will allow the use of default locations for saving the performance data that are legal for users in the E3SM project but which will not be legal for E3SM users who are not part of the project. These external users can define alternative locations in their job cases. BFB Fixes #1816 * origin/worleyph/cime/e3sm_perf_archiving: Modifying warning message when archiving of timing data is disabled (4) Modifying warning message when archiving of timing data is disabled (3) Modifying warning message when archiving of timing data is disabled (2) Modifying warning message when archiving of timing data is disabled Make similar changes in _save_postrun_timing_acme function Disable performance archiving if timing dir. can not be written into
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prior implementation was a bit too simple. Always giving the user
10 percent of nodes as spare nodes was way overkill for large jobs.
The new implementation maxes out the number of spare nodes at 10.
We also add a new variable to allow the user to pick the exact number
of spare nodes that they want.
Test suite: scripts_regression_tests T_TestRunRestart
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]
Fixes [CIME Github issue #]
User interface changes?: Yes, new case variables controlling spare nodes
Update gh-pages html (Y/N)?: N
Code review: @jedwards4b