Fix bug in case.run where arg skip-preview-namelist is out of sequence #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedwards4b
approved these changes
Jun 23, 2017
jgfouca
approved these changes
Jun 26, 2017
jgfouca
deleted the
sarich/scripts/fix-skip-preview-namelist-parsing-order
branch
jgfouca
pushed a commit
that referenced
this pull request
Oct 17, 2017
Check for NaNs and INFs in input to shr_reprosum_calc: In recent development NaNs and INFs are often first identified when passed to the shr_reprosum_calc routine, where they either lead to segmentation faults or to very slow performance (due to the interaction of NaNs and INFs with the reproducible sum logic). To more readily identify this error condition (and to prevent false attributions of error to shr_reprosum_calc), the input array is checked for the presence of NaNs and INFs. If found, an appropriate error message is output and the job is terminated. [BFB]
jgfouca
pushed a commit
that referenced
this pull request
Feb 23, 2018
Check for NaNs and INFs in input to shr_reprosum_calc: In recent development NaNs and INFs are often first identified when passed to the shr_reprosum_calc routine, where they either lead to segmentation faults or to very slow performance (due to the interaction of NaNs and INFs with the reproducible sum logic). To more readily identify this error condition (and to prevent false attributions of error to shr_reprosum_calc), the input array is checked for the presence of NaNs and INFs. If found, an appropriate error message is output and the job is terminated. [BFB]
jgfouca
pushed a commit
that referenced
this pull request
Mar 13, 2018
Check for NaNs and INFs in input to shr_reprosum_calc: In recent development NaNs and INFs are often first identified when passed to the shr_reprosum_calc routine, where they either lead to segmentation faults or to very slow performance (due to the interaction of NaNs and INFs with the reproducible sum logic). To more readily identify this error condition (and to prevent false attributions of error to shr_reprosum_calc), the input array is checked for the presence of NaNs and INFs. If found, an appropriate error message is output and the job is terminated. [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arg parsing needs to be done after adding arguments
master is broken on acme mira/cetus and blues/anvil without this fix
Test suite: acme_developer on anvil
Test baseline:
Test namelist changes:
Test status:
Fixes #1690
User interface changes?:
Update gh-pages html (Y/N)?:
Code review: