Updated grid aliases in cesm/config_grids.xml #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that do not specify the mask.
jedwards4b
requested changes
May 22, 2017
config/cesm/config_grids.xml
Outdated
| @@ -8,11 +8,11 @@ | |||
| ========================================= | |||
| The notation for the grid longname is | |||
| a%name_l%name_oi%name_r%name_m%mask_g%name_w%name | |||
| where | |||
| where | |||
There was a problem hiding this comment.
Please avoid adding unnecessary whitespace to files, it makes the review process difficult. Most editors can be configured to do this.
config/cesm/config_grids.xml
Outdated
| @@ -1655,6 +1550,17 @@ | |||
| <map name="ROF2OCN_ICE_RMAPNAME">cpl/cpl6/map_r01_to_gx1v6_120711.nc</map> | |||
| </gridmap> | |||
|
|
|||
| <!--- river flooding variables --> | |||
There was a problem hiding this comment.
These don't belong in this file and were removed in PR #1535
added 2 commits
May 22, 2017 10:07
…aliases that do not specify the mask." This reverts commit f7f33a2.
mvertens
approved these changes
May 23, 2017
jedwards4b
approved these changes
May 23, 2017
rljacob
added
Responsibility: CESM
fischer-ncar
added a commit
that referenced
this pull request
May 24, 2017
Reverts #1585 We need to back this out until the components are ready to comply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed grid aliases that do not specify the mask.
Renamed grid aliases so the mask specifier always follow the ocean grid.
Test suite:
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes
User interface changes?:
Code review: