Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed old ncl utilities. Changed the random pertlim generator to a… #1457

Merged
merged 2 commits into from
May 3, 2017
Merged

Conversation

allibco
Copy link
Collaborator

@allibco allibco commented May 2, 2017

Removed old ncl utilities. Changed the random pertlim generator to allow more (and flexible) number of ensemble members. Added the capability to generate 9 time step ensembles for UF-CAM-ECT.

Test suite:
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes: compatible with pyCECT v3.0
User interface changes?: yes

Code review:

…low more (and flexible) number of ensemble members. Added the capability to generate 9 time step ensembles for UF-CAM-ECT.
@jedwards4b jedwards4b self-assigned this May 2, 2017
@jedwards4b
Copy link
Contributor

First please reedit the initial description and fill in the template, removing and replacing text in [].

@@ -4,7 +4,7 @@
# $Id$
# $URL$
#
# Sets up a 12-month ne30_ne30 run
# Sets up a 12-month or ninth time step ne30_ne30 run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nine not ninth

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - i'll fix

@@ -293,7 +308,7 @@ case $MACH in
;;
esac

NewCaseFlags="$NewCaseFlags -res $RES -compset $COMPSET"
NewCaseFlags="$NewCaseFlags -res $RES -compset $COMPSET --run-unsupported --project $ACCOUNT"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use prefered syntax with double dash (--res --compset)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want me to make it so all must be -- ? Can you clarify :)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-dashes are required in most cases so fix as many as possible and note here any that cannot be fixed. See PR #1393.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok thanks - i'll try to fix

@rljacob rljacob added the ready label May 3, 2017
@allibco
Copy link
Collaborator Author

allibco commented May 3, 2017

OK, I believe I've made the requested changes - and I updated the README file accordingly

@jedwards4b jedwards4b merged commit 00c22c0 into ESMCI:master May 3, 2017
@jedwards4b jedwards4b removed the ready label May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants