Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need better test case coverage in cime_developer #646

Closed
jgfouca opened this issue Oct 6, 2016 · 8 comments
Closed

Need better test case coverage in cime_developer #646

jgfouca opened this issue Oct 6, 2016 · 8 comments

Comments

@jgfouca
Copy link
Contributor

jgfouca commented Oct 6, 2016

We are currently only testing NCK, ERI, SEQ, ERS, ERR, and SMS.

Untested: ERP, ERT, ICP, LII, NCR, NOC, PEA, PEM, PET, PFS, REP, SSP

It seems like we should be testing most if not all of these nightly.
@rljacob
Copy link
Member

rljacob commented Oct 7, 2016

After discussion: LII and SSP can't be tested in CIME. Others can't easily be tested in CIME without full component models.

@rljacob
Copy link
Member

rljacob commented Oct 7, 2016

Can we use fake tests?

@jgfouca
Copy link
Contributor Author

jgfouca commented Apr 7, 2017

I forgot about this issue. This is fairly important if we want to guarantee that things like PET will work for our users. @rljacob this should be assigned to someone so that we don't forget; not sure who the best person is, probably one of the Jims.

@rljacob rljacob added the ready label Apr 14, 2017
@jgfouca jgfouca mentioned this issue Apr 24, 2017
Merged
@ghost ghost added in progress and removed ready labels Apr 24, 2017
@ghost ghost removed the in progress label Apr 25, 2017
jedwards4b added a commit that referenced this issue Apr 25, 2017
@jedwards4b
Merge pull request #1414 from ESMCI/jgfouca/pet_fix_plus_coverage
f59dd4d 
Update case members in case_setup
Also, ACME is making heavy use of PET, so it needs to be tested
in cime_developer.

Test suite: scripts_regression_tests Z_FullSystemTest
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #646

User interface changes?: Adds PET test to cime_developer, PET behavior change

Code review: @jedwards4b
@rljacob
Copy link
Member

rljacob commented Apr 25, 2017

So PET is now tested but what about the others from that list?

@rljacob rljacob reopened this Apr 25, 2017
@jgfouca
Copy link
Contributor Author

jgfouca commented Apr 26, 2017

@rljacob , maybe I have my ACME hat on here too much, but at this point, every test that ACME cares about is tested.

@rljacob
Copy link
Member

rljacob commented Apr 26, 2017 •
edited
Loading

Well I think this issue should be viewed with a CIME hat on. The test types are a feature provided by CIME and so CIME should test them.

@jgfouca
Copy link
Contributor Author

jgfouca commented Apr 26, 2017

@rljacob probably but this is a case where I understand PET and it is testable in CIME standalone and that's not the case for the others. I'll go ahead an unassign myself because I have no plans to do further work on this in the near term.

@jgfouca
Copy link
Contributor Author

jgfouca commented Apr 26, 2017

Hah, you already did that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rljacob @jgfouca @mvertens