Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

":" in test-id name causes error during build #433

Closed
cacraigucar opened this issue Aug 19, 2016 · 3 comments
Closed

":" in test-id name causes error during build #433

cacraigucar opened this issue Aug 19, 2016 · 3 comments
Assignees
@jedwards4b

Comments

@cacraigucar
Copy link
Contributor

When I issue the command:
./create_test --xml-machine yellowstone --xml-compiler intel --xml-category aux_cam --test-id aux_cam_10:58:37

the job attempts to run, but there are misleading errors during compilation. I would suggest that if the above name is not a valid name, then the error should be trapped and reported as such. If it is a valid name, then a different fix will need to be made.

According to @gold2718 this behavior is also in the cime4, so it appears to be a bug that was migrated.
@billsacks
Copy link
Member

Is this a duplicate of CESM-Development#334 (but adding ':' to the list of disallowed characters), or is this a different issue (i.e., unrelated to the validity of the case name itself)?

@cacraigucar
Copy link
Contributor Author

I tested this again and this error still exists

@erichlf
Copy link

erichlf commented Apr 19, 2017

@cacraigucar what was the recent command you tried to use? Trying to use the original command doesn't work due to unknown options it seems.

@jedwards4b jedwards4b mentioned this issue Apr 19, 2017
Merged
@ghost ghost assigned jedwards4b Apr 19, 2017
@ghost ghost added the in progress label Apr 19, 2017
@ghost ghost removed the in progress label Apr 20, 2017
jgfouca added a commit that referenced this issue Apr 20, 2017
@jgfouca
Merge pull request #1383 from jedwards4b/new_illegal_char
4fb16a1 
add illegal char : to check_name test

It needs to be illegal for both case names and test ids (for case names it was okay until the build and then gmake had problems)

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #433

User interface changes?: do not allow ':' in testid or case name.

Code review:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jedwards4b jedwards4b

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@erichlf @jedwards4b @billsacks @cacraigucar