-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIME calls cprnc in a non-symmetric way #4303
Comments
I can reproduce this issue. I think that it should do a symmetric test. |
It would be enough to use the highest precision between the two fields. Or maybe check that the two have the same precision, and return a diff if they don't (the likelihood of a |
Here is my proposed solution
If it is in the second file:
In either case additional information is available in cprnc output:
@bartgol will this meet your needs? |
Yes, I think it's great. Thanks! |
add a data type check to cprnc Add a check to assure that data types are the same in compared files. Test suite: by hand, ./scripts_regression_tests.py test_sys_cime_case.test_self_build_cprnc --compiler gnu Test baseline: Test namelist changes: Test status: bit for bit Fixes #4303 User interface changes?: Update gh-pages html (Y/N)?:
I changed the output precision of a test from double to float. I was expecting baseline tests to fail, but our tests still passed.
Intrigued, I manually ran cprnc and indeed it reported 0 diffs. However, flipping the files order did show the difference. I'm guessing cprnc chooses the precision from the 1st file (which, for me, was float), so even if the second file has higher precision, it does not see that.
Is this desired? Should CIME do a symmetric test instead? Or is this too much of a corner case to be worth cime mods?
The text was updated successfully, but these errors were encountered: