Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Look for buildcpp, buildnml, and buildlib in SourceMods #1727

Closed
mnlevy1981 opened this issue Jul 10, 2017 · 0 comments
Closed

Look for buildcpp, buildnml, and buildlib in SourceMods #1727

mnlevy1981 opened this issue Jul 10, 2017 · 0 comments
Assignees
@jedwards4b
Labels
tp: config ty: enhancement

Comments

@mnlevy1981
Copy link
Contributor

We found a bug in one of the POP build scripts, and the user who found (and eventually fixed) the issue was surprised that the updated script needed to be tested in a sandbox rather than by dropping it in SourceMods. If it's not too much hassle, it would be great if CIME could look for these three scripts in SourceMods before falling back to the component's cime_config directory.
@jedwards4b jedwards4b self-assigned this Jul 10, 2017
@jedwards4b jedwards4b mentioned this issue Jul 12, 2017
Merged
jgfouca added a commit that referenced this issue Jul 12, 2017
@jgfouca
Merge pull request #1730 from jedwards4b/build_scripts_in_SourceMods
69f0128 
Build scripts in source mods

Allow the buildnml and buildlib scripts for each component to be located in the SourceMods subdirectories of the case. Clean up some of the buildlib structure.

Test suite: scripts_regression_tests.py, hand tests with files in SourceMods.
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1727

User interface changes?:

Update gh-pages html (Y/N)?:Y a minor change was made

Code review:
@ghost ghost removed the in progress label Jul 12, 2017
jgfouca added a commit that referenced this issue Oct 17, 2017
@jgfouca
Merge branch 'jgfouca/cime/fix_timer_vals' into master (PR #1727)
d09a5ff 
Fix values for TIMER_DETAIL and TIMER_LEVEL

These got mixed-up in CIME somehow.

Fixes #1655

[BFB]

* jgfouca/cime/fix_timer_vals:
  Address GitHub feedback
  Fix values for TIMER_DETAIL and TIMER_LEVEL
jgfouca added a commit that referenced this issue Feb 23, 2018
@jgfouca
Merge branch 'jgfouca/cime/fix_timer_vals' into master (PR #1727)
a00bbba 
Fix values for TIMER_DETAIL and TIMER_LEVEL

These got mixed-up in CIME somehow.

Fixes #1655

[BFB]

* jgfouca/cime/fix_timer_vals:
  Address GitHub feedback
  Fix values for TIMER_DETAIL and TIMER_LEVEL
jgfouca added a commit that referenced this issue Mar 13, 2018
@jgfouca
Merge branch 'jgfouca/cime/fix_timer_vals' into master (PR #1727)
a2f76fd 
Fix values for TIMER_DETAIL and TIMER_LEVEL

These got mixed-up in CIME somehow.

Fixes #1655

[BFB]

* jgfouca/cime/fix_timer_vals:
  Address GitHub feedback
  Fix values for TIMER_DETAIL and TIMER_LEVEL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jedwards4b jedwards4b

Labels
tp: config ty: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mnlevy1981 @jedwards4b