-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document testing #1295
Comments
This is a partly a duplicate of #1060 |
Currently documentation of unit testing (http://esmci.github.io/cime/doc/build/html/misc_tools/unit_testing.html) is under "Misc tools". To me it feels like it would fit better under "CIME User’s Guide Part 2: CIME internals, Porting, Testing and Use Cases". How do others feel about that? |
I agree with you - it should go under testing.
…On Fri, Apr 21, 2017 at 1:38 PM, Bill Sacks ***@***.***> wrote:
Currently documentation of unit testing (http://esmci.github.io/cime/
doc/build/html/misc_tools/unit_testing.html) is under "Misc tools". To me
it feels like it would fit better under "CIME User’s Guide Part 2: CIME
internals, Porting, Testing and Use Cases". How do others feel about that?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1295 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHlxE-5YVdtkis1bjWSGnvyvD57hlHQcks5ryOmigaJpZM4Mw9tc>
.
|
I am in favor of the move. As long as CIME is monolithic (no 'optional' or 'external' pieces), I think there should be one place for documentation. |
The "testing" in part 2 is a placeholder for documentation of create_test. "Misc tools" is for everything in the cime/tools directory. |
And everything in cime/tools is "optional" in the sense you don't need it for the core functioning of cime. |
I think that unit testing belongs with testing in the documentation and
therefore should accompany the part 2 documentation.
…On Fri, Apr 21, 2017 at 8:47 PM, Robert Jacob ***@***.***> wrote:
And everything in cime/tools is "optional" in the sense you don't need it
for the core functioning of cime.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1295 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHlxE9exrp9cIPqAiDTEsOVt83HFzpZsks5ryWpEgaJpZM4Mw9tc>
.
|
@rljacob - I made a new section in Part 2 - after "Testing with create_test" I added "Fortran unit testing" - see http://esmci.github.io/cime/doc/build/html/users_guide/index.html#users-guide2 . My rationale was that unit testing is (or should be) no more of an "optional" tool than system testing is. |
I agree unit testing should be encouraged. But "tools" is still for optional parts of CIME so if unit testing is now as crucial a part of CIME as the system tests, we should move tools/unit_testing somewhere else. If its just for testing fortran, we should move it to "src". |
That's an interesting and valid point. Lets discuss this at the Wednesday
meeting.
…On Mon, Apr 24, 2017 at 9:57 PM, Robert Jacob ***@***.***> wrote:
I agree unit testing should be encouraged. But "tools" is still for
optional parts of CIME so if unit testing is now as crucial a part of CIME
as the system tests, we should move tools/unit_testing somewhere else. If
its just for testing fortran, we should move it to "src".
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1295 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AHlxE2nOsWJa080Mse5OiXaGeGdo5EjQks5rzW9EgaJpZM4Mw9tc>
.
|
Adding docs. |
Merge origin/singhbalwinder/atm/endrun-for-clubb-singular-matrix-error into next (PR #1295) This PR also adds endrun calls if other errors are detected by the CLUBB routines. [BFB] - Bit-For-Bit
clearer documentation is needed in CIME regarding both the use of create_test AND the use of scripts-regressions-test. For the latter, it is not clear at all how to understand and fix failures.
The text was updated successfully, but these errors were encountered: