Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document testing #1295

Closed
mvertens opened this issue Apr 2, 2017 · 11 comments
Closed

document testing #1295

mvertens opened this issue Apr 2, 2017 · 11 comments
Assignees
Milestone

Comments

@mvertens
Copy link
Contributor

mvertens commented Apr 2, 2017

clearer documentation is needed in CIME regarding both the use of create_test AND the use of scripts-regressions-test. For the latter, it is not clear at all how to understand and fix failures.

@mvertens mvertens added this to the cesm2 milestone Apr 2, 2017
@rljacob
Copy link
Member

rljacob commented Apr 3, 2017

This is a partly a duplicate of #1060

@jgfouca jgfouca added the ready label Apr 6, 2017
@billsacks
Copy link
Member

Currently documentation of unit testing (http://esmci.github.io/cime/doc/build/html/misc_tools/unit_testing.html) is under "Misc tools". To me it feels like it would fit better under "CIME User’s Guide Part 2: CIME internals, Porting, Testing and Use Cases". How do others feel about that?

@mvertens
Copy link
Contributor Author

mvertens commented Apr 21, 2017 via email

@gold2718
Copy link

I am in favor of the move. As long as CIME is monolithic (no 'optional' or 'external' pieces), I think there should be one place for documentation.

@rljacob
Copy link
Member

rljacob commented Apr 22, 2017

The "testing" in part 2 is a placeholder for documentation of create_test. "Misc tools" is for everything in the cime/tools directory.

@rljacob
Copy link
Member

rljacob commented Apr 22, 2017

And everything in cime/tools is "optional" in the sense you don't need it for the core functioning of cime.

@mvertens
Copy link
Contributor Author

mvertens commented Apr 22, 2017 via email

@billsacks
Copy link
Member

@rljacob - I made a new section in Part 2 - after "Testing with create_test" I added "Fortran unit testing" - see http://esmci.github.io/cime/doc/build/html/users_guide/index.html#users-guide2 . My rationale was that unit testing is (or should be) no more of an "optional" tool than system testing is.

@rljacob
Copy link
Member

rljacob commented Apr 25, 2017

I agree unit testing should be encouraged. But "tools" is still for optional parts of CIME so if unit testing is now as crucial a part of CIME as the system tests, we should move tools/unit_testing somewhere else. If its just for testing fortran, we should move it to "src".

@mvertens
Copy link
Contributor Author

mvertens commented Apr 25, 2017 via email

@jgfouca
Copy link
Contributor

jgfouca commented May 4, 2017

Adding docs.

@jgfouca jgfouca closed this as completed May 4, 2017
@ghost ghost removed the ready label May 4, 2017
jgfouca pushed a commit that referenced this issue Jun 2, 2017
Merge origin/singhbalwinder/atm/endrun-for-clubb-singular-matrix-error into next (PR #1295)

This PR also adds endrun calls if other errors are detected by the CLUBB routines.

[BFB] - Bit-For-Bit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants