Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to skip preview_namelist during case.run #1276

Closed
rljacob opened this issue Mar 24, 2017 · 2 comments
Closed

Add option to skip preview_namelist during case.run #1276

rljacob opened this issue Mar 24, 2017 · 2 comments
Assignees
@erichlf
Labels
tp: user interface

Comments

@rljacob
Copy link
Member

rljacob commented Mar 24, 2017 •
edited
Loading

Add an option to case.submit to skip calling preview_namelist during case.run. This is for low-powered compute nodes that are spending a lot of time in preview_namelist. Its up to the user to not modify any xml files while the job is in the queue.
@rljacob
Copy link
Member Author

rljacob commented Mar 24, 2017

Should the option also skip the calling of create_namelist by case.submit? Tagging @mvertens

@rljacob rljacob changed the title Add option to skip create_namelist during case.run Add option to skip preview_namelist during case.run Mar 24, 2017
@rljacob rljacob mentioned this issue Mar 25, 2017
Closed
@rljacob rljacob added the ready label Mar 31, 2017
@rljacob
Copy link
Member Author

rljacob commented Apr 27, 2017

We need to bump this up in priority. From an ACME user:

I submitted a debug job this morning on Edison:

The job started at 2017-04-27 10:32:40
The model started running at 2017-04-27 10:39:09
It took over 6 minutes (out of a maximum of 30 for the debug queue) for CIME to do its thing before the model would start.

@jgfouca jgfouca assigned erichlf and unassigned jgfouca Apr 27, 2017
@erichlf erichlf added in progress and removed ready labels Apr 27, 2017
erichlf pushed a commit that referenced this issue May 3, 2017
Added '--skip-preview-namelist' to case.build
863f30f 
Added '--skip-preview-namelist' to case.build. This will allow the user
to specify if the namelist should be rebuilt from user_nl_8.

In this particular commit I added '--skip-preview-namelist' to the call
for case.build in the testing suite, since building namelists during
tests isn't done.

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1276, E3SM-Project/E3SM#1466 (comment)

User interface changes?: Added --skip-preview-namelist to case.build and
template.case.run

Code review: @jgfouca, @rljacob
@erichlf erichlf mentioned this issue May 3, 2017
Merged
erichlf pushed a commit that referenced this issue May 4, 2017
Added '--skip-preview-namelist' to case.build
5c36b36 
Added '--skip-preview-namelist' to case.build. This will allow the user
to specify if the namelist should be rebuilt from user_nl_8.

In this particular commit I added '--skip-preview-namelist' to the call
for case.build in the testing suite, since building namelists during
tests isn't done.

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1276, E3SM-Project/E3SM#1466 (comment)

User interface changes?: Added --skip-preview-namelist to case.build and
template.case.run

Code review: @jgfouca, @rljacob
erichlf pushed a commit that referenced this issue May 4, 2017
Added skip-pnl to cesm's template.case.run
c290b8e 
Added the new skip-preview-namelist option to the cesm version of
template.case.run.

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1276

User interface changes?: Adds --skip-preview-namelist

Code review: @jgfouca, @rljacob
erichlf pushed a commit that referenced this issue May 4, 2017
Fixed Some Issues which Reappeared
bb6fecc 
After a rebase from master a few issues reappeared. Most issues were
typos or wrong function handle used. I have fixed these issues.

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1276

User interface changes?: Added skip-preview-namelist option

Code review: @rljacob, @jgfouca
erichlf pushed a commit that referenced this issue May 5, 2017
Fixed Issues as per @jgfouca
b06ebb8 
Fixed some indentation inconsistencies, removed the tuple from usage in
parser, fixed logical for skip_pnl and continue_run, and finally fixed
some consistency in strings.

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1276, E3SM-Project/E3SM#1466

User interface changes?:
Added --skip-preview-namelist to case.build and
template.case.run

Code review: @jgfouca, @rljacob
erichlf pushed a commit that referenced this issue May 8, 2017
Fixed Logic for CONTINUE_RUN as per @jgfouca
f94d6fd 
 Removed the logic for skip_pnl in the CONTINUE_RUN portion of the code as
 per @jgfouca

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1276, E3SM-Project/E3SM#1466

User interface changes?: Added --skip-preview-namelist option to
case.submit

Code review: @jgfouca, @rljacob
erichlf pushed a commit that referenced this issue May 9, 2017
Added '--skip-preview-namelist' to case.build
f221a52 
Added '--skip-preview-namelist' to case.build. This will allow the user
to specify if the namelist should be rebuilt from user_nl_8.

In this particular commit I added '--skip-preview-namelist' to the call
for case.build in the testing suite, since building namelists during
tests isn't done.

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1276, E3SM-Project/E3SM#1466 (comment)

User interface changes?: Added --skip-preview-namelist to case.build and
template.case.run

Code review: @jgfouca, @rljacob
erichlf pushed a commit that referenced this issue May 9, 2017
Added skip-pnl to cesm's template.case.run
c92cc9a 
Added the new skip-preview-namelist option to the cesm version of
template.case.run.

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1276

User interface changes?: Adds --skip-preview-namelist

Code review: @jgfouca, @rljacob
erichlf pushed a commit that referenced this issue May 9, 2017
Fixed Some Issues which Reappeared
668be81 
After a rebase from master a few issues reappeared. Most issues were
typos or wrong function handle used. I have fixed these issues.

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1276

User interface changes?: Added skip-preview-namelist option

Code review: @rljacob, @jgfouca
erichlf pushed a commit that referenced this issue May 9, 2017
Fixed Issues as per @jgfouca
6e0f510 
Fixed some indentation inconsistencies, removed the tuple from usage in
parser, fixed logical for skip_pnl and continue_run, and finally fixed
some consistency in strings.

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1276, E3SM-Project/E3SM#1466

User interface changes?:
Added --skip-preview-namelist to case.build and
template.case.run

Code review: @jgfouca, @rljacob
erichlf pushed a commit that referenced this issue May 9, 2017
Fixed Logic for CONTINUE_RUN as per @jgfouca
5a6d393 
 Removed the logic for skip_pnl in the CONTINUE_RUN portion of the code as
 per @jgfouca

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1276, E3SM-Project/E3SM#1466

User interface changes?: Added --skip-preview-namelist option to
case.submit

Code review: @jgfouca, @rljacob
@ghost ghost removed the in progress label May 9, 2017
jgfouca added a commit that referenced this issue May 9, 2017
@jgfouca
Merge pull request #1471 from ESMCI/erichlf/case_submit/skip_pnl
cdcb096 
Add skip-preview-namelist to case.submit and case_run

Added '--skip-preview-namelist' to case.build

Added '--skip-preview-namelist' to case.build. This will allow the user
to specify if the namelist should be rebuilt from user_nl_*.

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1276, E3SM-Project/E3SM#1466

User interface changes?: Added --skip-preview-namelist to case.build and
template.case.run

Code review: @jgfouca, @rljacob, @jedwards4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erichlf erichlf

Labels
tp: user interface
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rljacob @erichlf @jgfouca