Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option for ERS tests? #1244

Closed
mnlevy1981 opened this issue Mar 14, 2017 · 1 comment
Closed

New option for ERS tests? #1244

mnlevy1981 opened this issue Mar 14, 2017 · 1 comment
Assignees

Comments

@mnlevy1981
Copy link
Contributor

Right now, if you run an ERS_Ld5 test then CIME does the following:

  1. Run for 5 days, writing restart file after day 3
  2. Go back to the day 3 restart file, run for 2 days (days 4 & 5)
  3. Compare the output from step 1 and step 2

I'd like an option to run the test in the following manner:

  1. Run for 5 days without writing a restart file
  2. Run for 3 days (days 1 - 3) and write a restart file at the end of the run
  3. Continue the run for 2 days (days 4 & 5)
  4. Compare the output from step 1 and step 3

It is extra work (initializing the model three times instead of twice and running an additional three days), but POP has a "feature" where writing a restart history file changes the eventual history file1 that is written... so if we have a test that computes 5-day averages for tavg output then the current version of the ERS test will PASS and the proposed option will FAIL. Having a test that fails in this situation would be handy for when we fix this feature.

1 Two notes... the change in the history file is round-off level, so it isn't terrible that the test currently passes. Also, the change is due to the fact that the POP restart history file is a normalized version of the accumulation buffer so writing a restart file normalizes the buffer, writes it, and then denormalizes it (hence the pass -- in the current test step 1 denormalizes the buffer after writing the restart and step 2 denormalizes it in an identical fashion after reading the restart). The proposed fix to POP is to write the denormalized buffer into the restart history file.

@gold2718
Copy link

My vote would be to make @mnlevy1981's 'option' the default usage. I've always been a bit suspicious that the current ERS test properly tests normal CESM restart usage.

@jgfouca jgfouca self-assigned this Apr 6, 2017
@jgfouca jgfouca added the ready label Apr 6, 2017
@ghost ghost added in progress and removed ready labels May 4, 2017
@ghost ghost removed the in progress label May 5, 2017
jedwards4b added a commit that referenced this issue May 5, 2017
Make alternative implementation for ERS
Creatively named ERS2. First phase does no restarts. Second phase does two runs,
the first run makes a restart file and stops, second run resumes and then compares
to the first phase.

Test suite: ERS2 test, code checker
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1244

User interface changes?: new ERS2 test type

Code review: @jedwards4b @mnlevy1981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants