Inconsistencies in new FindpFUnit.cmake #1147
Assignees
Labels
Comments
jedwards4b
pushed a commit
to jedwards4b/cime
that referenced
this issue
Feb 15, 2017
This PR addresses an issue which makes the model non-deterministic (i.e. non-BFB) when run with more than one thread. PR ESMCI#1147 introduced a logical variable (cldfsnow_logic) which was declared and assigned at module level. This kind of declaration automatically sets a variable with 'SAVE' attribute which in turn makes the variable a shared variable (to be shared by all the threads). This PR removes this variables and retain the same functionality. Fixes ESMCI#1203 [BFB] - Bit-For-Bit
jedwards4b
pushed a commit
to jedwards4b/cime
that referenced
this issue
Feb 15, 2017
Merge branch 'singhbalwinder/atm/fix-non-BFB-threading-runs' (PR ESMCI#1219) This PR addresses an issue which makes the model non-deterministic (i.e. non-BFB) when run with more than one thread. PR ESMCI#1147 introduced a logical variable (cldfsnow_logic) which was declared and assigned at module level. This kind of declaration automatically sets a variable with 'SAVE' attribute which in turn makes the variable a shared variable (to be shared by all the threads). This PR removes this variables and retain the same functionality. Fixes ESMCI#1203 [BFB] - Bit-For-Bit
agsalin
pushed a commit
that referenced
this issue
Mar 23, 2017
Adds 3 new atmospheric compsets - (2000, 1850 and 20TR) AV1C-04P2 This PR adds 3 new atmospheric compsets which includes a revised tuning after the RRTMG, CLUBB and MG bugfixes. Three new flags are added to maintain BFB reproducability. PR #1124 fixes one of these bugs directly without using a flag. Flags used in this PR must be REMOVED at a latter time. A new issue will be created to track removal of these flags. [BFB] - Bit-For-Bit [NML] - Namelist Changing * singhbalwinder/atm/av1c-04p2: Fixes leftover paranthesis Fixes a newly created logical variable in an if condition Adds 3 new atmospheric compsets - (2000, 1850 and 20TR) AV1C-04P2
agsalin
pushed a commit
that referenced
this issue
Mar 23, 2017
This PR addresses an issue which makes the model non-deterministic (i.e. non-BFB) when run with more than one thread. PR #1147 introduced a logical variable (cldfsnow_logic) which was declared and assigned at module level. This kind of declaration automatically sets a variable with 'SAVE' attribute which in turn makes the variable a shared variable (to be shared by all the threads). This PR removes this variables and retain the same functionality. Fixes #1203 [BFB] - Bit-For-Bit
agsalin
pushed a commit
that referenced
this issue
Mar 23, 2017
Merge branch 'singhbalwinder/atm/fix-non-BFB-threading-runs' (PR #1219) This PR addresses an issue which makes the model non-deterministic (i.e. non-BFB) when run with more than one thread. PR #1147 introduced a logical variable (cldfsnow_logic) which was declared and assigned at module level. This kind of declaration automatically sets a variable with 'SAVE' attribute which in turn makes the variable a shared variable (to be shared by all the threads). This PR removes this variables and retain the same functionality. Fixes #1203 [BFB] - Bit-For-Bit
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #1135 introduced some inconsistencies in FindpFUnit.cmake, which should be resolved:
HINTS $ENV{PFUNIT}/bin)was changed toHINTS ${PFUNIT_PATH}/bin). But pFUnit itself suggests using the environment variable PFUNIT, and this cmake find utility was designed to honor that. Can we have both hints? Also note that tools/unit_testing/README refers to setting the environment variable PFUNIT in order for things to Just Work, so if this is kept as is, we should at least update the README.There are some inconsistencies: for
find_library(PFUNIT_LIBRARY pfunit,HINTS ${pfunit_directory}/lib)was changed toHINTS ${PFUNIT_PATH}/lib), but similar uses of pfunit_directory were not changed. I'm guessing this was an oversight, but I don't understand this well enough to know.The text was updated successfully, but these errors were encountered: