Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of xsd:decimal instead of xsd:double for conversion factors #231

Closed
jmkeil opened this issue Dec 7, 2020 · 2 comments · Fixed by #269
Closed

Use of xsd:decimal instead of xsd:double for conversion factors #231

jmkeil opened this issue Dec 7, 2020 · 2 comments · Fixed by #269
Labels

Comments

@jmkeil
Copy link
Contributor

jmkeil commented Dec 7, 2020

Using a comparison of unit ontologies with ABECTO I became aware that SWEET uses xsd:double to represent conversion factors and offsets. I think, instead xsd:decimal should be used, as binary floating point datatypes are not able to exactly represent many of the conversion values. Especially 0.1, 0.01, 0.001, … can not be represented. Only the lexical representation seems to be exact. However, the lexical to value mapping will map them to a slightly different value. This runs the risk of numerical problems in applications. I outlined this in detail in arXiv:2011.08077.

@jmkeil jmkeil added the bug label Dec 7, 2020
@dr-shorthair
Copy link
Collaborator

+1 from me.

I just made related PR in QUDT - qudt/qudt-public-repo#311
and OM is coming up behind HajoRijgersberg/OM#42

@lewismc
Copy link
Member

lewismc commented Jan 21, 2021

@jmkeil thanks for registering the issue. Are you able to provide a pull request? If not, one of us can get around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants