Fix memory increase during download (leak) #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After any completed download on a single File, the last chunk was not released and lived in memory until all files have been downloaded. This fix releases any chunk from memory (rather marks it as garbage for later collection) right after it has been written to the temporary file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After any completed download on a single File, the last chunk was not released and lived in memory until all files have been downloaded.
Changes
httpx.AsyncClientstrategy to use the same client across the lifetime of aProcessorobject (e.g. during the lifetime of a singleesgpull downloadcommand).