Feature/update kwt #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmizukami
reviewed
Mar 5, 2018
route/build/src/kwt_route.f90
Outdated
| INTEGER(I4B), INTENT(IN) :: JRCH ! reach to process | ||
| integer(i4b), intent(in) :: ixDesire ! index of the desired reach |
There was a problem hiding this comment.
comment is not clear. should like " index of the reach to print the results on screen" or something like that?
| @@ -655,6 +660,14 @@ SUBROUTINE REACH_LIST(& | |||
| structSEG(iRch)%var(ixSEG%totalArea)%dat(1) = structSEG(iRch)%var(ixSEG%basArea)%dat(1) + & | |||
| structSEG(iRch)%var(ixSEG%upsArea)%dat(1) | |||
|
|
|||
| ! ---------- define good basins --------------------------------------------------------- | |||
|
|
|||
There was a problem hiding this comment.
i think need to define what the good basin is here.
"goodBasin" == Drainage area at the bottom of the reach is greater than threshold, "verySmall" value.
route/build/src/network_topo.f90
Outdated
| @@ -548,6 +551,7 @@ SUBROUTINE REACH_LIST(& | |||
| integer(i4b) , intent(out) :: ierr ! error code | |||
| character(*) , intent(out) :: message ! error message | |||
| ! local variables | |||
| real(dp), parameter :: verySmall=tiny(1.0_dp) ! a very small number | |||
There was a problem hiding this comment.
verySmall is defined in public.f90.
Now, not clear what to be stored in public.f90, globalData.f90. maybe have to have some rule.
route/build/src/process_ntopo.f90
Outdated
| @@ -65,6 +68,7 @@ subroutine ntopo(& | |||
| ! -------------------------------------------------------------------------------------------------------------- | |||
| ! local variables | |||
| character(len=strLen) :: cmessage ! error message of downwind routine | |||
| real(dp), parameter :: min_slope=1.e-6_dp ! minimum slope | |||
There was a problem hiding this comment.
Should this be in public.f90?
route/build/src/kwt_route.f90
Outdated
| @@ -25,7 +25,7 @@ module kwt_route | |||
| public::qroute_rch | |||
|
|
|||
| ! common variables | |||
| integer(i4b),parameter :: ixPrint = -9999 ! the desired reach (set to negative to avoid any printing) | |||
| integer(i4b),save :: ixPrint = -9999 ! the desired reach (set to negative to avoid any printing) | |||
| real(dp),parameter :: verySmall=tiny(1.0_dp) ! a very small number | |||
|
Addressed all comments raised during code review. |
nmizukami
pushed a commit
to nmizukami/mizuRoute
that referenced
this pull request
Oct 22, 2020
Feature/mpi pio
ekluzek
pushed a commit
to ekluzek/mizuRoute
that referenced
this pull request
Nov 30, 2022
Get DTEST NUOPC restart capability working
ekluzek
pushed a commit
to ekluzek/mizuRoute
that referenced
this pull request
Dec 1, 2022
…build Changes needed for the mksurfdata_esmf build Fixes ESCOMP#36 I've only tested in the context of mksurfdata_esmf so far: I also did the following tests on izumi and they PASS: ERS_Ld3.f19_g17.X.izumi_intel ERS_Ld3.f45_g37_rx1.A.izumi_intel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating code to include kinematic wave routing