-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change time to equal the middle of time_bounds #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
fix area scaling to correct RTM river flux to MOM6 fix how area is applied to input runoff for rtm
slevis-lmwg
changed the title
'I' fields: now on separate htape; non-'I' flds: time = mid-time_bounds
Change time to equal the middle of time_bounds
Oct 18, 2024
This was referenced Oct 18, 2024
on derecho: |
Update testlist_rtm
@ekluzek this is ready for your approval before I can merge. |
Then this will be rtm1_0_82. |
ekluzek
approved these changes
Nov 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is just doing the same thing as is being put into CTSM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTM equivalent to CTSM work done in ESCOMP/CTSM#2838
Relates to issue #32 but does not resolve the separation of instantaneous variables onto separate history files.
@slevis-lmwg will track here also the prerequisite work happening in #54/#55.