Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change time to equal the middle of time_bounds #39

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

slevis-lmwg
Copy link
Contributor

@slevis-lmwg slevis-lmwg commented Aug 1, 2023

RTM equivalent to CTSM work done in ESCOMP/CTSM#2838

Relates to issue #32 but does not resolve the separation of instantaneous variables onto separate history files.

@slevis-lmwg will track here also the prerequisite work happening in #54/#55.

@slevis-lmwg

This comment was marked as resolved.

fix area scaling to correct RTM river flux to MOM6

fix how area is applied to input runoff for rtm
@slevis-lmwg slevis-lmwg changed the title 'I' fields: now on separate htape; non-'I' flds: time = mid-time_bounds Change time to equal the middle of time_bounds Oct 18, 2024
@slevis-lmwg
Copy link
Contributor Author

slevis-lmwg commented Nov 8, 2024

on derecho:
OK ./run_sys_tests -s rtm -c rtm1_0_81-ctsm5.2.009 -g rtm1_0_82-ctsm5.2.009

@slevis-lmwg slevis-lmwg marked this pull request as ready for review November 9, 2024 01:22
@slevis-lmwg
Copy link
Contributor Author

@ekluzek this is ready for your approval before I can merge.

@slevis-lmwg slevis-lmwg requested a review from ekluzek November 9, 2024 01:24
@slevis-lmwg
Copy link
Contributor Author

Then this will be rtm1_0_82.

Copy link
Contributor

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is just doing the same thing as is being put into CTSM.

@slevis-lmwg slevis-lmwg merged commit 1d10716 into ESCOMP:master Nov 11, 2024
@slevis-lmwg slevis-lmwg deleted the time_var_rtm_iss32 branch November 11, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants