Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running 0th timestep #37

Merged
merged 5 commits into from
Nov 12, 2024
Merged

Stop running 0th timestep #37

merged 5 commits into from
Nov 12, 2024

Conversation

olyson
Copy link
Contributor

@olyson olyson commented Aug 1, 2023

Changes needed to stop running 0th timestep.
See CTSM issue ESCOMP/CTSM#925 and PR ESCOMP/CTSM#2084

@slevis-lmwg
Copy link
Contributor

@jedwards4b you reviewed and approved the mosart equivalent of this (ESCOMP/MOSART#67) so would you be willing to confirm that this is also ready to approve?

Copy link
Contributor

@jedwards4b jedwards4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is exactly the same as mosart.

time in hist now equals the middle of the time_bounds

RTM equivalent to CTSM work done in ESCOMP/CTSM#2838
Answers change only for the time variable.
@slevis-lmwg
Copy link
Contributor

@jedwards4b from your message that this is like mosart and that you approved I understand that I can go ahead and resolve your question and prepare to merge. Let me know if I misunderstood.

@slevis-lmwg
Copy link
Contributor

slevis-lmwg commented Nov 12, 2024

derecho testing
OK ./run_sys_tests -s rtm -c rtm1_0_82-ctsm5.2.009 -g rtm1_0_83-ctsm5.2.011

  • WHEN DONE, RENAME 5.2 TO 5.3 IN THE BASELINE NAMES.

@slevis-lmwg slevis-lmwg merged commit a2cd824 into ESCOMP:master Nov 12, 2024
@slevis-lmwg
Copy link
Contributor

This is now rtm1_0_83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants