Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add timestamp to rpointer files #105

Merged
merged 9 commits into from
Dec 25, 2024

Conversation

jedwards4b
Copy link
Contributor

Add timestamps to rpointer files, initialize curr date from driver and compare to what is in the restart files (instead of initializing from restart files).

@wwieder
Copy link

wwieder commented Sep 25, 2024

I see this is no longer a draft. Are you ready for a review, Jim?

@jedwards4b
Copy link
Contributor Author

@wwieder Note that this is for mosart and is ready for review. I will update the clm PR tomorrow.

@wwieder
Copy link

wwieder commented Sep 26, 2024

Thanks for making the mosart PR. What's the priority and timing of this across CESM?

@jedwards4b
Copy link
Contributor Author

I would like this to go into the cesm3_0_beta04 tag - probably within 30-45 days.

@wwieder
Copy link

wwieder commented Oct 3, 2024

Is this ready to go now, Jim?

@jedwards4b
Copy link
Contributor Author

yes

@slevis-lmwg
Copy link
Contributor

@ekluzek when ready to merge this to master, remember that I merged to master the ChangeLog update without making a new tag.

#108

Eliminate 0th time step from MOSART simulations
@ekluzek
Copy link
Contributor

ekluzek commented Dec 21, 2024

Initial testing shows tests passing on Derecho and comparing exactly to the baseline as expected.

Copy link
Contributor

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as I had for the CTSM PR. I've done them there, will be easier to do the same here.

src/cpl/nuopc/rof_comp_nuopc.F90 Show resolved Hide resolved
src/riverroute/mosart_timemanager.F90 Outdated Show resolved Hide resolved
src/riverroute/mosart_timemanager.F90 Show resolved Hide resolved
@ekluzek ekluzek merged commit a246344 into ESCOMP:master Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: release/externals tags done
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants