Remove Copyright file #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussion from ESCOMP#997: I noticed that we have an old "Copyright" file at the top level of the repository, that is both out of date and incorrect – critically, using the legally incorrect term, "public domain". I recently updated this file in CESM: ESCOMP/CESM#141 However, I'd suggest that we simply remove this file from CTSM. It's not clear to me that we really need to maintain this file, since other code isn't included in our repository but rather downloaded separately via manage_externals, and I think it's confusing to have separate LICENSE and COPYRIGHT files. However, we may want to have a note in the LICENSE file saying that this license only applies to the code in this repository, and that externals obtained via manage_externals have their own licenses.
billsacks
added
PR status: ready
|
@ekluzek if you approve, I'll merge this directly to master, but won't make a tag. |
ekluzek
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Remove Copyright file
Specific notes
Discussion from #997:
I noticed that we have an old "Copyright" file at the top level of the
repository, that is both out of date and incorrect – critically, using
the legally incorrect term, "public domain".
I recently updated this file in CESM: ESCOMP/CESM#141
However, I'd suggest that we simply remove this file from CTSM. It's not
clear to me that we really need to maintain this file, since other code
isn't included in our repository but rather downloaded separately via
manage_externals, and I think it's confusing to have separate LICENSE
and COPYRIGHT files. However, we may want to have a note in the LICENSE
file saying that this license only applies to the code in this
repository, and that externals obtained via manage_externals have their
own licenses.
Contributors other than yourself, if any: none
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed, if any: None