Fixed Biogeeography: FATES_NEXT_API #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
glemieux
added
the
FATES
rgknox
added
FATES API update
ekluzek
added
PR status: work in progress
enhancement
|
@glemieux I added some labels to this. It sounds like this is just the changes needed on the FATES side, so a new FATES version will need to be made and added into the changes here. As such it seems like it's "Work in Progress" so I labeled it as such. Feel free to change that status if I got it wrong. |
|
Adding in specific test call. Cross posting: NGEET/fates#632 (comment) |
This is to capture the updated test from latest fates suite tests
…ory structure. Also renamed
Adding in test suite definition and pre-merge
Deconflict CTSM PR 985 with fates_next_api (commit d525994)
Adding fix for pft indexing bounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This implements changes to pass the weight of the PFTs on the naturally vegetated land unit into FATES for their use in fixed biogeography mode. It also implements the switch (use_fates_fixed_biogeog) that turns that capability on and off (off by default).
Specific notes
This corresponds to this item in the reduced complexity modes project. https://github.com/NGEET/fates/projects/5#card-36625297
THIS PR SHOULD BE ADOPTED AT THE SAME TIME AS THE CORRESPONDING FATES_API PR
NGEET/fates#632
Contributors other than yourself, if any:
@rgknox , @ckoven , @ekluzek , @glemieux
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)?
Yes, but only when use_fates_fixed_biogeog is TRUE.
Any User Interface Changes (namelist or namelist defaults changes)?
Yes (implements use_fates_fixed_biogeog )
Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on cheyenne for intel/gnu and izumi for intel/gnu/nag/pgi is the standard for tags on master)
Tested the code at 4x5 resolution though four years of annual restarts.
Test run output on cheyenne here:
/glade/scratch/rfisher/archive/clm5-spfates_test/lnd/hist
This passes carbon balance checks. I didn't test whether it changes answers when it is off.
running from
/glade/work/rfisher/git/ctsm_apr20/cime/scripts/clm5-spfates_test
NOTE: Be sure to check your Coding style against the standard:
https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines