interface changes for fates-parteh (nutrients) #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fates-np-api
rgknox
added
FATES API update
ekluzek
reviewed
Jul 30, 2019
ekluzek
reviewed
Jul 30, 2019
ekluzek
approved these changes
Jul 30, 2019
AGonzalezNicolas
pushed a commit
to HPSCTerrSys/clm5_0
that referenced
this pull request
Jun 27, 2024
interface changes for fates-parteh (nutrients)
AGonzalezNicolas
pushed a commit
to HPSCTerrSys/clm5_0
that referenced
this pull request
Jul 5, 2024
interface changes for fates-parteh (nutrients)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This set of changes has modifications that support multiple elements (nutrients) in FATES. There will be more changes in the future that will focus specifically on CLM side hypotheses, and how they couple with fates, however the current set of changes just focuses on the following:
Note item 4, and this may have impacts on non-fates code.
Specific notes
This is syncronized with: NGEET/fates#524
Are answers expected to change (and if so in what way)?
These changes should not change any model states not associated with FATES. These changes could potentially enable other modules to make use of 2D history output, where the second dimension is length 1.
Any User Interface Changes (namelist or namelist defaults changes)? no
Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on cheyenne for gnu/pgi and hobart for gnu/pgi/nag is the standard for tags on master)
Testing is TBD
@bishtgautam , I will be submitting very similar changes to ELM in the near future, including changes to the history.
NOTE: Be sure to check your Coding style against the standard:
https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines