fates refactor of 3d arrays in restart - api changes #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructures following restart
rgknox
added
FATES API update
rosiealice
approved these changes
Oct 30, 2018
rgknox
added
PR status: ready
AGonzalezNicolas
pushed a commit
to HPSCTerrSys/clm5_0
that referenced
this pull request
Jun 27, 2024
fates refactor of 3d arrays in restart - api changes
AGonzalezNicolas
pushed a commit
to HPSCTerrSys/clm5_0
that referenced
this pull request
Jul 5, 2024
fates refactor of 3d arrays in restart - api changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
In PR NGEET/fates#428, we refactor fates restarts so that we don't need to save some massive restart variables. However, we do need to initiate a call early in the restart process that will re-create these arrays (radiation absorbtion fractions). However, we can't re-use any existing calls through the interface.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Fates issue: NGEET/fates#12
Are answers expected to change (and if so in what way)?
hard to say, results should be nigh b4b, but the order of operations will change slightly, so I'm expecting very small round-off errors, but possibly not...
Any User Interface Changes (namelist or namelist defaults changes)?
no
Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on cheyenne for gnu/pgi and hobart for gnu/pgi/nag is the standard for tags on master)
Test Output:
All PASS: cheyenne, intel, fates test suite:
/gpfs/fs1/scratch/rgknox/clmed-tests/fates.cheyenne.intel.C46895e9-F3c87f2a-pft-arrays-vf3
NOTE: Be sure to check your Coding style against the standard:
https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines