Fates parteh api #537
Merged
Fates parteh api #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgknox
added
FATES API update
ckoven
reviewed
Oct 23, 2018
| @@ -196,6 +196,9 @@ module clm_varctl | |||
| logical, public :: use_fates = .false. ! true => use fates | |||
|
|
|||
| ! These are INTERNAL to the FATES module | |||
| integer, public :: fates_parteh_mode = -9 ! 1 => carbon only | |||
There was a problem hiding this comment.
@rgknox what does the -9 mean here?
There was a problem hiding this comment.
it is a bogus initialization value, that will force the model to fail if not set correctly.
There was a problem hiding this comment.
ok, let's add a comment to that effect in case its not obvious.
Suggested change
| integer, public :: fates_parteh_mode = -9 ! 1 => carbon only | |
| integer, public :: fates_parteh_mode = -9 ! 1 => carbon only; -9 => junk value that will force fail unless reset later |
rgknox
added
PR status: ready
|
FATES side changes have been integrated. All tests pass. |
ekluzek
added a commit
to ekluzek/CTSM
that referenced
this pull request
Mar 9, 2019
…tesvers Author: Ryan Knox <[email protected]> Date: Wed Oct 24 13:05:11 2018 -0700 Merge pull request ESCOMP#537 from rgknox/fates-parteh-api Fates parteh api
AGonzalezNicolas
pushed a commit
to HPSCTerrSys/clm5_0
that referenced
this pull request
Jun 27, 2024
Fates parteh api
AGonzalezNicolas
pushed a commit
to HPSCTerrSys/clm5_0
that referenced
this pull request
Jun 27, 2024
…tesvers Author: Ryan Knox <[email protected]> Date: Wed Oct 24 13:05:11 2018 -0700 Merge pull request ESCOMP#537 from rgknox/fates-parteh-api Fates parteh api
AGonzalezNicolas
pushed a commit
to HPSCTerrSys/clm5_0
that referenced
this pull request
Jul 5, 2024
Fates parteh api
AGonzalezNicolas
pushed a commit
to HPSCTerrSys/clm5_0
that referenced
this pull request
Jul 5, 2024
…tesvers Author: Ryan Knox <[email protected]> Date: Wed Oct 24 13:05:11 2018 -0700 Merge pull request ESCOMP#537 from rgknox/fates-parteh-api Fates parteh api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
FATES has undergone a significant refactor of plant allocation, growth and turnover (aka PARTEH). To facilitate these refactors, a namelist variable has been added which swaps the different modes or hypotheses that are executed. Some history variables are also no longer in the output files and had to be removed from tests.
Synced with: NGEET/fates#421
Specific notes
Contributors other than yourself, if any:
The FATES developer team.
CTSM Issues Fixed (include github issue #):
None
Are answers expected to change (and if so in what way)?
These changes must be syncronized with a new FATES release. The FATES release should not be B4B, no non-fates code or tests should be effected.
Any User Interface Changes (namelist or namelist defaults changes)?
yes! Added fates_parteh_mode = INT
Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on cheyenne for gnu/pgi and hobart for gnu/pgi/nag is the standard for tags on master)
fates test suite, cheyenne, intel, all PASS (not b4b)
30 year, 14 PFT, f45 grid, smoke-test (PASS)
multi-decade comparison of biomass, leaf area and carbon fluxes against master at a tropical site.
NOTE: Be sure to check your Coding style against the standard:
https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines