Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPE change to sa_leaf in CanopyFluxesMod.F90 #2788

Merged
merged 5 commits into from
Oct 14, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions doc/ChangeLog
slevis-lmwg marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,4 +1,72 @@
===============================================================
Tag name: ctsm5.3.008
Originator(s): olyson (Keith Oleson,UCAR/TSS)
Date: Mon 14 Oct 2024 11:56:12 AM MDT
One-line Summary: PPE change to sa_leaf in CanopyFluxesMod.F90

Purpose and description of changes
----------------------------------

Add change to sa_leaf that was in PPE branch but did not get on master.


Significant changes to scientifically-supported configurations
--------------------------------------------------------------

Does this tag change answers significantly for any of the following physics configurations?
(Details of any changes will be given in the "Answer changes" section below.)

[Put an [X] in the box for any configuration with significant answer changes.]

[X] clm6_0

[X] clm5_1

[X] clm5_0

[X] ctsm5_0-nwp

[X] clm4_5


Bugs fixed
----------
List of CTSM issues fixed (include CTSM Issue # and description) [one per line]:
Fixes #2777


Testing summary:
----------------

[PASS means all tests PASS; OK means tests PASS other than expected fails.]

regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing):

derecho -----
izumi -------


Answer changes
--------------

Changes answers relative to baseline: Yes

Summarize any changes to answers, i.e.,
- what code configurations: All
- what platforms/compilers: All
- nature of change: larger than roundoff/same climate)

The changes in answers are explained in this post:
https://github.com/ESCOMP/CTSM/issues/2777#issuecomment-2371697380


Other details
-------------
Pull Requests that document the changes (include PR ids):
https://github.com/ESCOMP/ctsm/pull/2788

===============================================================
===============================================================
Tag name: ctsm5.3.007
Originator(s): slevis (Samuel Levis,UCAR/TSS,303-665-1310)
Date: Mon 13 Oct 2024 11:04:18 AM MDT
Expand Down
1 change: 1 addition & 0 deletions doc/ChangeSum
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
Tag Who Date Summary
============================================================================================================================
ctsm5.3.008 olyson 10/14/2024 PPE change to sa_leaf in CanopyFluxesMod.F90
ctsm5.3.007 slevis 10/14/2024 Clm60 finidat updates for ne30, f09, f19 grids
ctsm5.3.006 samrabin 10/11/2024 Merge b4b-dev
ctsm5.3.005 erik 10/10/2024 Hardcoded tuning adjustments for Leung_2024 dust emissions
Expand Down
1 change: 1 addition & 0 deletions src/biogeophys/CanopyFluxesMod.F90
Original file line number Diff line number Diff line change
Expand Up @@ -753,6 +753,7 @@ subroutine CanopyFluxes(bounds, num_exposedvegp, filter_exposedvegp,
.or. dbh(p) < min_stem_diameter) then
frac_rad_abs_by_stem(p) = 0.0_r8
sa_stem(p) = 0.0_r8
sa_leaf(p) = sa_leaf(p) + esai(p)
endif

! if using Satellite Phenology mode, calculate leaf and stem biomass
Expand Down
Loading