Fates fuel refactor #2782
Merged
Fates fuel refactor #2782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
all aux_clm and fates test suite tests PASS (or expected fail) except for BASELINE DIFFs as expected: aux_clm: /glade/derecho/scratch/afoster/tests_0924-165752de fates: /glade/derecho/scratch/afoster/tests_0924-151742de confirming that DIFFs are round off as expected. Will report back |
samsrabin
added
FATES API update
glemieux
approved these changes
Oct 21, 2024
|
@adrifoster would you be ok with me pushing an update to address #2850 here? |
sure! |
This addresses ESCOMP#2580
added 3 commits
October 29, 2024 15:19
This reverts commit e9fb075.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Companion to FATES PR 1247
Specific notes
Just updates the location of a constant.
Are answers expected to change (and if so in what way)?
FATES PR does change answers for FATES cases, but changes are round-off due to some order of operations changes.
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
Running aux_clm and fates suites