Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes to li2024 fire #2726

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Bug fixes to li2024 fire #2726

merged 4 commits into from
Aug 23, 2024

Conversation

samsrabin
Copy link
Collaborator

Description of changes

  • Allow non-agricultural fire in tropical closed forests in the last timestep of the month
  • li2024 fire now fully obeys cli_scale (b4b change because default parameter matched the magic number)

Specific notes

Contributors other than yourself, if any: @lifang0209

CTSM Issues Fixed (include github issue #):

Are answers expected to change (and if so in what way)? Only for li2024 fire_methods, which are not on by default.

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any:

  • aux_clm in progress

@samsrabin samsrabin added bug something is working incorrectly priority: Immediate Highest priority, something that was unexpected science Enhancement to or bug impacting science labels Aug 23, 2024
@samsrabin samsrabin self-assigned this Aug 23, 2024
@samsrabin samsrabin added this to the CESM3 Capability Freeze milestone Aug 23, 2024
@wwieder wwieder self-requested a review August 23, 2024 15:30
@samsrabin samsrabin merged commit 72691ea into ESCOMP:master Aug 23, 2024
1 of 2 checks passed
@lifang0209
Copy link

incorporate the impact of O₂ concentration on fuel flammability to address the fire overestimation in Tibet:
(1) Add:
forc_po2 => atm2lnd_inst%forc_po2_grc , & ! Input: [real(r8) (:) ] O2 partial pressure (Pa)

(2) fire_m should be changed to:
fire_m = ((afuel*arh30+(1._r8-afuel)*arh)**1.5_r8) &
*((1._r8-btran_col(c)/wtlf(c))**0.5_r8) &
*min(1._r8, max(0._r8, (forc_po2(g)-15000)/2500._r8))

@lifang0209
Copy link

lifang0209 commented Aug 23, 2024

@samsrabin, don't forget to update the parameter file in /glade/derecho/scratch/fangli/firedata. I'm not sure how you update the parameter file. Do I need to list the parameters I've modified, or does your system automatically identify the changed parameters and replace them?

@samsrabin
Copy link
Collaborator Author

@samsrabin, don't forget to update the parameter file in /glade/derecho/scratch/fangli/firedata. I'm not sure how you update the parameter file. Do I need to list the parameters I've modified, or does your system automatically identify the changed parameters and replace them?

Yep! I've done that as described here. The new parameters will be brought in sometime over the next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is working incorrectly priority: Immediate Highest priority, something that was unexpected science Enhancement to or bug impacting science
Projects
Status: Done (non release/external)
Development

Successfully merging this pull request may close these issues.

Minor bugs in li2024 fire
3 participants