[Fang summer '24 PR 2.1] More improvements to fire model #2711
Conversation
…ppression. - Previously, neither lightning nor human ignitions (other than deforestation fire) were allowed there. - Landscape fragmentation suppression effect has to do with lfwt.
Same as li2024gswpfrc except rh_hgh now 85 (was 80).
samsrabin
added
enhancement
There was a problem hiding this comment.
This is great, thanks for working on this and getting it in quickly.
I have a question and a couple suggestions on changes to the namelist items at top. Those are the things I think you should do now. I'm marking as approve just so you don't have to wait on me to reapprove later.
There's a couple things looking at the code got me thinking about for longer term. There's two things that maybe you could do now.
The simple thing is redo code indentation because of an if statement that we removed. That's easy enough in VS code.
The only thing that might be good to do now would be to add some comments to explain what's going on in the code bits that change. If you could add something on that now -- that would be good to explain. But, if you need to get with Fang that could be done later.
samsrabin
changed the title
Value above which 30-day running relative humidity has no effect on fuel combustibility.
"PFT-dependent thresholds of P60d and P10d" in Li et al. (2013, doi:10.5194/bg-10-2293-2013): - defo_fire_precip_thresh_bet: Value (mm/d) above which running mean daily precipitation (10 or 60 days) does not allow deforestation fire for a column with broadleaf evergreen tropical trees but no broadleaf deciduous tropical trees. - defo_fire_precip_thresh_bdt: Vice versa
- nonborpeat_fire_precip_denom: Denominator of precipitation in equation relating that to non-boreal peat fire (unitless). Eq. 9 in Li et al. (2013, doi:10.5194/bg-10-2293-2013). - borpeat_fire_soilmoist_denom: Denominator of exponential in soil moisture term of equation relating that and temperature to boreal peat fire (unitless). Eq. 10 in Li et al. (2013, doi:10.5194/bg-10-2293-2013).
There was a problem hiding this comment.
These additions are really good. Thanks for bringing it in, and it looks like it was required for the new Li2024 work. Love to see more fire magic numbers turned into variables.
The one change I have is to add d00 to the end of the namelist parameters so that the constants are all double precision. You might not be able to replicate previous results without it. And it's an important practice to have.
But, nice work here. Thanks.
|
Made those changes @ekluzek. Could you re-approve? Tests are running now. |
|
@samsrabin (2) |
Description of changes
(Supersedes #2615, which was the same as this but on the 2021 module instead of the new 2024 module.)
fire_methodli2024crujra.Specific notes
Contributors other than yourself, if any: @lifang0209
CTSM Issues Fixed (include github issue #): None
Are answers expected to change (and if so in what way)? Yes, but only for
fire_methodli2024gswpfrc.Any User Interface Changes (namelist or namelist defaults changes)?
fire_methodli2024gswpfrc.fire_methodli2024crujra.Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
firesuite performs as expected: diffs only inli2024gswpfrctest.aux_clmsuite to be run before merging this PR