Fix cam dust emiss control #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MIS_DRV_FLDS is FALSE
…elist to use to determine dust_emis settings, still check that they aren't set in the user_nl_clm file
…elds that weren't being set in CLM
…7.FHIST.derecho_intel.cam-outfrq9s test
|
#2709 blocks the fix for this working. |
…ns allowed are much more complex now, this resolves ESCOMP#2709
ekluzek
added
enhancement
Get it working with bringing in the CAM drv_flds_in file. And make it not matter on the --megan --drydep --fire_emis options. Also do dust_emis before the other drv_flds_in namelists, so the CAM namelist is loaded.
ekluzek
commented
Aug 22, 2024
… issue regarding it
…r clm6_0_cam6.0, that came about due to XML code duplication
…pen because you can set drv_flds_in settings without using the CLM_BLDNML_OPTS options for it
slevis-lmwg
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
@ekluzek gave me and Will a guided explanation of this PR. This resolves immediate needs with temporary fixes. These will be revisited later with longer term solutions. Thanks, Erik!
|
@fvitt and I went over this on a high level and agreed to what's being done here for the short term. I don't like some of what's being done, but think it's OK for the short term. And since this tag needs to happen ASAP we will go with what we have working here. |
ekluzek
added
PR status: ready
…ons that they add testing namelists, but you can always add the fields to user_nl_clm even when they are turned off
…-no-megan build-namelist options
…mand line options to build-namelist -drydep, -fire_emis and -no-megan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fix dust emissions control when running coupled to CAM.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Fixes #2687
Fixes #2709
Fixes #2712
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)?
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: will be regular
So far just running namelist testing