Handle CAM7 #2632
Merged
Handle CAM7 #2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekluzek
added
enhancement
slevis-lmwg
requested changes
Jul 5, 2024
There was a problem hiding this comment.
@ekluzek I caught a few things, and I may have missed others, because I did not go through every new line in this PR. Let me know if it would be helpful to review it again together.
Co-authored-by: Samuel Levis <[email protected]>
Make the Regular Expressions more consistent. Don't allow the use of CLM51 for all options. Make CPLHIST CAM version depend on which CLM version is used. Make sure explicit matches for CAM60 are there.
Add some comments to talk about what kind of land tuning mode is being done for a section of finidat files.
|
@slevis-lmwg I think I handled all of your suggested changes. So please re-review and let me know if I missed something. |
…tests (as Zender won't be the option for cam7)
|
Testing on Derecho has one PEM test that failed with answer changes on different number of processors. PEM_D_Ld9.ne30pg3_t232.I1850Clm60BgcCropG.derecho_intel.clm-clm60cam7LndTuningMode As a first go, I'll rerun it a couple times to see if I see the same behavior. Then start looking into those variables. This is just issue #2542 |
This was referenced Jul 9, 2024
slevis-lmwg
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Changes so that CAM7 is allowed for the land-tuning mode. Allow "C" and "E" after period designation in long compset names. Fix some important issues.
Specific notes
Contributors other than yourself, if any: @jedwards4b
CTSM Issues Fixed (include github issue #):
Fixes #2480
Fixes #2634
Fixes #2637
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)?
LND_TUNING_MODE for cam7.0 is now allowed
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any: Will run regular testing
So far doing namelist unit testing and namelist testing within CESM