Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor ssp_anomaly_forcing #2235

Merged
merged 13 commits into from
Nov 15, 2023

Conversation

samsrabin
Copy link
Collaborator

Description of changes

Refactors ssp_anomaly_forcing script to make it easier to read and more amenable to future development.

I originally started this in an attempt to resolve this script "stalling out" for me, but was unsuccessful—see #2181, which I'm now closing. I didn't want that work to go to waste, though, so I figured I would finish the refactor and submit that.

Specific notes

Contributors other than yourself, if any: @wwieder

CTSM Issues Fixed (include github issue #): None

Are answers expected to change (and if so in what way)? Adds attributes to write_climo files' dimension variables.

Any User Interface Changes (namelist or namelist defaults changes)?

  • Adds --output-dir option. Default ./anomaly_forcing reproduces previous behavior.
  • Makes synonyms for options with hyphens replacing underscores.

Testing performed, if any: Compared files for (a) write_climo, (b) tas, and (c) WIND generated with 389bca9 (only superficial changes) and 2b45ef4 (latest commit on branch).

@samsrabin samsrabin added test: none No tests required (e.g. tools/contrib) tag: support tools only labels Nov 6, 2023
@samsrabin samsrabin self-assigned this Nov 6, 2023
@slevis-lmwg slevis-lmwg merged commit 6713de7 into ESCOMP:master Nov 15, 2023
@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit test: none No tests required (e.g. tools/contrib)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants