Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cropcalStreamMod compiler error bug fix #2233

Merged

Conversation

adrifoster
Copy link
Collaborator

Description of changes

Fixes a compiler error (for GNU 13.2) within cropcalStreamMod

Specific notes

Simple fix was to change whole-array assignments/references for the starts and ends arrays to specifically reference bounds (begp and endp).

Contributors other than yourself, if any: @billsacks

CTSM Issues Fixed (include github issue #): Closes #2232

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any:

Successfully compiles with GNU 13.2

@adrifoster adrifoster requested a review from samsrabin November 3, 2023 20:43
Copy link
Collaborator

@samsrabin samsrabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I just found some lines where some extra whitespace seems to have been inserted, leading to apparent diffs that really aren't. If you could revert that, that'd be great; no need for me to re-review so I'll approve now.

Thanks again!

src/cpl/share_esmf/cropcalStreamMod.F90 Outdated Show resolved Hide resolved
src/cpl/share_esmf/cropcalStreamMod.F90 Outdated Show resolved Hide resolved
src/cpl/share_esmf/cropcalStreamMod.F90 Outdated Show resolved Hide resolved
src/cpl/share_esmf/cropcalStreamMod.F90 Outdated Show resolved Hide resolved
src/cpl/share_esmf/cropcalStreamMod.F90 Outdated Show resolved Hide resolved
@adrifoster
Copy link
Collaborator Author

Looks good, thanks! I just found some lines where some extra whitespace seems to have been inserted, leading to apparent diffs that really aren't. If you could revert that, that'd be great; no need for me to re-review so I'll approve now.

sorry about that, fixed now!

@samsrabin samsrabin added tag: simple bfb PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete labels Nov 9, 2023
@slevis-lmwg slevis-lmwg merged commit 51ee378 into ESCOMP:master Nov 15, 2023
@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
@adrifoster adrifoster deleted the cropcalstreammod_compiler_bug_fix branch September 24, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

COMPILER ERROR problem in cropcalStreamMod
3 participants