-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNICAR snow albedo scheme updates #1861
Merged
Merged
Changes from 13 commits
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
a625eac
add output for SNICAR related albedo variables
cenlinhe 759ef18
bug fix for adding new albedo output variables
cenlinhe e3c5459
expand SNICAR from 5-band to 480-band with namelist control option
cenlinhe 314c7d3
add adding-doubling solver in SNICAR with namelist option
cenlinhe 3e9299f
add nonspherical snow grains with namelist option
cenlinhe e006dc5
add BC-snow internal mixing and namelist control
cenlinhe 43e52bf
add dust-snow internal mixing and namelist control
cenlinhe 7dc18ab
bug fix for BC/dust-snow internal mixing
cenlinhe 9d5fee6
update 5-band input optics database & move DO_SNO_OC to namelist control
cenlinhe a6e168e
add DO_SNO_OC to namelist_definition_ctsm
cenlinhe 7191233
bug fix for albsni_hst2
cenlinhe 83991f7
correcting default values for new SNICAR namelist options
cenlinhe b4a30d6
Merge remote-tracking branch 'escomp/master' into snicar_allupdate
slevis-lmwg a6422a2
Merge remote-tracking branch 'escomp/master' into snicar_allupdate
slevis-lmwg 32ca5ec
snicar_snw_optics: keep option 3 only
slevis-lmwg 725f527
snicar_rt_solver: keep option 2 only
slevis-lmwg 5f8d50d
snicar_snw_shape: replace integers with descriptive options
slevis-lmwg 3164bc6
snicar_solarspec & snicar_dust_optics: replace integers with descript…
slevis-lmwg 230e3fc
General clean-up of other snicar switches and comments
slevis-lmwg 4ab6738
Some clean-up associated with snicar_numrad_snw
slevis-lmwg 21b607d
Update namelist defaults and differentiate clm5_1 from 5_0, 4_5
slevis-lmwg 604968e
Minor cleanup of unnecessary things
slevis-lmwg 9cd7a55
Minor cleanup of unused things
slevis-lmwg a0cd959
Rename use_snicar_frc to snicar_aerforc_diag and make default .false.
slevis-lmwg 0e6f1df
Correction of a typo in /testmods_dirs/.../user_nl_clm
slevis-lmwg 55e91e4
Replace dimension 8 with ngmax for two arrays; wait to hear about others
slevis-lmwg 992ef0f
Minor refactor: replace some / and ** with *, replace some ifs with m…
slevis-lmwg 5ddaa34
Correct comments that label hydrophilic/phobic OC and BC
slevis-lmwg d47da29
Consolidated fsnowoptics480 with fsnowoptics
slevis-lmwg afbe2d6
Add quotes to correct namelist_defaults_ctsm.xml
slevis-lmwg 9808d1a
Consolidate some repetitive code pertaining to wvl_ct
slevis-lmwg 5ad655a
Reduce repetitive code in 'Weight output NIR albedo' section
slevis-lmwg 40bcf15
Reduce repetitive code in 'Weight output NIR absorbed' section
slevis-lmwg 98f229a
Replace if-statements with min/max
slevis-lmwg 2ee70af
Replace another if-statmt with max and two ints with floats
slevis-lmwg 2a4159d
Merge remote-tracking branch 'escomp/master' into snicar_allupdate
slevis-lmwg 5709993
Add a clarifying comment to the code
slevis-lmwg a5e8c7c
Draft of ChangeLog/Sum files
slevis-lmwg 093e54c
Update to the ChangeLog
slevis-lmwg f0b6d60
Update2 to the ChangeLog
slevis-lmwg ab5b8f4
Merge remote-tracking branch 'escomp/master' into snicar_allupdate
slevis-lmwg 557e664
Merge remote-tracking branch 'escomp/master' into snicar_allupdate
slevis-lmwg d4be616
Merge tag 'ctsm5.1.dev139'
slevis-lmwg 1b0f7a2
Rm Defaults from snicar vars in namelist_definition
slevis-lmwg 27f3237
Rm one more Default
slevis-lmwg 0129068
Add licencing info to subr. piecewise_linear_interp1d
slevis-lmwg 05ea928
Add readv argument to call ncd_io in SnowSnicarMod (not tested, yet)
slevis-lmwg 8cf2c70
Updates to last commit for test to PASS
slevis-lmwg ffc8eae
Replace 3600 with secsphr
slevis-lmwg 55ad199
Replace indices 1, 2 with ivis, inir where appropriate
slevis-lmwg 33c8524
Replace 1e5 with enh_omg_max parameter
slevis-lmwg eb10335
Replace hardwired numbers with parameters and other clean-up
slevis-lmwg 3f0fe62
Changed many constants to parameters and other minor clean-up
slevis-lmwg 00493ef
Change some arrays to parameters
slevis-lmwg ed2a177
Change more arrays to parameters
slevis-lmwg eddb844
Add case default lines and corresponding error messages
slevis-lmwg d6b92ec
Change two more arrays to parameters
slevis-lmwg 99ee926
Replace suffixes 1 & 2 representing hydrophillic/phobic w hphil/hphob
slevis-lmwg 94846be
Replace pointers with allocatables
slevis-lmwg b892252
Improve error checks and comments
slevis-lmwg 20ce1ea
Remove option of running this copy of snicar in csim
slevis-lmwg f952e50
Replace hardwired numbers with parameters
slevis-lmwg eeba54f
Add comment explaining posNOTonfile=.true.
slevis-lmwg 67bf624
Merge remote-tracking branch 'escomp/master' into snicar_allupdate
slevis-lmwg 3838ceb
Correct syntax error
slevis-lmwg 3a4ffdc
Merge remote-tracking branch 'escomp/master' into snicar_allupdate
slevis-lmwg 6adba3d
Remove a bit of redundant code and change a comment
slevis-lmwg a2370a0
CLMBuildNamelist.pm: Put most snicar error checks in loop
slevis-lmwg f0260cf
Revert snicar_aerforc_diag to original use_snicar_frc
slevis-lmwg 1890865
Removing duplicate lines of code #2129 #2107
slevis-lmwg 44d128e
Merge branch 'master' into snicar_allupdate
slevis-lmwg 82a335a
Merge remote-tracking branch 'escomp/master' into snicar_allupdate
slevis-lmwg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make an issue to make these logical variables start with the CTSM "use_" prefix convention so you can readily see they are logical's. This is good for usability.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linking new issue #2205