Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FATES testdefs so that we use the compset instead of a testmod directory #1827

Merged
merged 8 commits into from
Oct 15, 2022

Conversation

adrifoster
Copy link
Collaborator

@adrifoster adrifoster commented Aug 11, 2022

Description of changes

Rearranged and edited some of the FATES testdefs files so that we just use the compset for FATES SP mode.

Specific notes

Contributors other than yourself, if any: @ekluzek

CTSM Issues Fixed (include github issue #):
Fixes #1817

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any:

Ran individual test cases for all changed tests. Running actual test suite next. Will report back results.

@adrifoster adrifoster requested a review from ekluzek August 11, 2022 20:47
@adrifoster
Copy link
Collaborator Author

As per discussion with @ekluzek I am going to revert back some of these changes to keep references to the FatesColdDef in most of the modified testdefs, but update one of the test lists (the FATES SP one) to use the new FatesColdDefBasic user mod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure at least one test running FatesSp just uses the compset and not a test-mod directory
3 participants