MIMICS into vertically resolved CTSM

src/biogeochem/CNCStateUpdate1Mod.F90

@@ -69,6 +69,14 @@ subroutine CStateUpdateDynPatch(bounds, num_soilc_with_inactive, filter_soilc_wi
        do j = 1,nlevdecomp
           do fc = 1, num_soilc_with_inactive
              c = filter_soilc_with_inactive(fc)
+             ! TODO BFB refactor: In loops like this, we will run into trouble
+             !      with MIMICS bc we will have 2 instead of 3 litter pools. Can
+             !      address with if statements (NOT ideal) or
+             !      turn these repetitive lines into a loop BUT to do that
+             !      we need to turn dwt_frootc_to_litr_* into a 3d var.
+             !      There are 3 such loops here, 2 in CNCStateUpdate2, and one
+             !      in CNCStateUpdate1 and the pattern repeats in the
+             !      corresponding N modules.
              cs_soil%decomp_cpools_vr_col(c,j,i_met_lit) = cs_soil%decomp_cpools_vr_col(c,j,i_met_lit) + &
                   cf_veg%dwt_frootc_to_litr_met_c_col(c,j) * dt
              cs_soil%decomp_cpools_vr_col(c,j,i_cel_lit) = cs_soil%decomp_cpools_vr_col(c,j,i_cel_lit) + &

src/main/clm_varpar.F90

@@ -9,7 +9,8 @@ module clm_varpar
   use shr_sys_mod  , only: shr_sys_abort
   use spmdMod      , only: masterproc
   use clm_varctl   , only: use_extralakelayers, use_vertsoilc
-  use clm_varctl   , only: use_century_decomp, use_c13, use_c14
+  use clm_varctl   , only: use_century_decomp, use_mimics_decomp
+  use clm_varctl   , only: use_c13, use_c14
   use clm_varctl   , only: iulog, use_crop, create_crop_landunit, irrigate
   use clm_varctl   , only: use_vichydro, rundef
   use clm_varctl   , only: soil_layerstruct_predefined
@@ -232,6 +233,9 @@ subroutine clm_varpar_init(actual_maxsoil_patches, actual_numcft)
        if (use_century_decomp) then
           ndecomp_pools = 6
           ndecomp_cascade_transitions = 8
+       else if (use_mimics_decomp) then
+          ndecomp_pools = ?
+          ndecomp_cascade_transitions = ?
        else
           ndecomp_pools = 7
           ndecomp_cascade_transitions = 7
@@ -241,6 +245,9 @@ subroutine clm_varpar_init(actual_maxsoil_patches, actual_numcft)
        if (use_century_decomp) then
           ndecomp_pools = 7
           ndecomp_cascade_transitions = 10
+       else if (use_mimics_decomp) then
+          ndecomp_pools = ?
+          ndecomp_cascade_transitions = ?
        else
           ndecomp_pools = 8
           ndecomp_cascade_transitions = 9

src/soilbiogeochem/SoilBiogeochemDecompCascadeConType.F90

@@ -27,6 +27,7 @@ module SoilBiogeochemDecompCascadeConType
      character(len=8)  , pointer  :: decomp_pool_name_history(:)       ! name of pool for history files
      character(len=20) , pointer  :: decomp_pool_name_long(:)          ! name of pool for netcdf long names
      character(len=8)  , pointer  :: decomp_pool_name_short(:)         ! name of pool for netcdf short names
+     logical           , pointer  :: is_microbe(:)                     ! TRUE => pool is a microbe pool
      logical           , pointer  :: is_litter(:)                      ! TRUE => pool is a litter pool
      logical           , pointer  :: is_soil(:)                        ! TRUE => pool is a soil pool
      logical           , pointer  :: is_cwd(:)                         ! TRUE => pool is a cwd pool
@@ -72,6 +73,7 @@ subroutine init_decomp_cascade_constants( use_century_decomp )
     allocate(decomp_cascade_con%decomp_pool_name_history(ibeg:ndecomp_pools))
     allocate(decomp_cascade_con%decomp_pool_name_long(ibeg:ndecomp_pools))
     allocate(decomp_cascade_con%decomp_pool_name_short(ibeg:ndecomp_pools))
+    allocate(decomp_cascade_con%is_microbe(ibeg:ndecomp_pools))
     allocate(decomp_cascade_con%is_litter(ibeg:ndecomp_pools))
     allocate(decomp_cascade_con%is_soil(ibeg:ndecomp_pools))
     allocate(decomp_cascade_con%is_cwd(ibeg:ndecomp_pools))
@@ -93,6 +95,7 @@ subroutine init_decomp_cascade_constants( use_century_decomp )
     decomp_cascade_con%decomp_pool_name_restart(ibeg:ndecomp_pools)       = ''
     decomp_cascade_con%decomp_pool_name_long(ibeg:ndecomp_pools)          = ''
     decomp_cascade_con%decomp_pool_name_short(ibeg:ndecomp_pools)         = ''
+    decomp_cascade_con%is_microbe(ibeg:ndecomp_pools)                     = .false.
     decomp_cascade_con%is_litter(ibeg:ndecomp_pools)                      = .false.
     decomp_cascade_con%is_soil(ibeg:ndecomp_pools)                        = .false.
     decomp_cascade_con%is_cwd(ibeg:ndecomp_pools)                         = .false.