Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New single column functionality for NUOPC/CMEPS #1309

Merged
merged 40 commits into from
Mar 31, 2021

Conversation

mvertens
Copy link

@mvertens mvertens commented Mar 19, 2021

Description of changes

New single column functionality for NUOPC/CMEPS

Specific notes

Implemented new nuopc/cmeps single column functionality.

In config/cesm/config_files.xml - single point domains are only used for mct/cpl7.
For cmeps single point meshes are now generated on the fly and component domains files are no longer needed.
env_run.xml variables PTS_LAT, PTS_LON and PTS_DOMAINFILE are used to determine if there is a single point or single column run.
If PTS_LAT and PTS_LON are not -999 and PTS_DOMAINFILE is UNSET, then you have a single point run and the exact values of PTS_LAT and PTS_LON are used.
If PTS_LAT and PTS_LON are not -999 and PTS_DOMAINFILE is not UNSET, then then the cmeps driver will recognize the nearest neighbor values of PTS_LAT and PTS_LON in PTS_DOMAINFILE as the single column lat and lon to use.

This PR only effects nuopc/cmeps configurations. New External entries are needed for CMEPS, CDEPS and CIME.

Contributors other than yourself, if any:

CTSM Issues Fixed:
Fixes #1312
Fixes #1302
Fixes #1183

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? New xml variables for NUOPC configurations

Testing performed, if any: Performed testing associated with doing a CMEPS/CDEPS PR.

@mvertens mvertens requested a review from ekluzek March 19, 2021 17:40
@ekluzek ekluzek self-assigned this Mar 19, 2021
@ekluzek ekluzek added PR status: work in progress priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations enhancement new capability or improved behavior of existing capability labels Mar 19, 2021
@ekluzek ekluzek added this to the ctsm5.1.0 milestone Mar 19, 2021
Copy link
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just flipped through this quickly (mostly leaving the review to @ekluzek ), but wanted to ask about a couple of changes I noticed.

src/cpl/nuopc/lnd_comp_nuopc.F90 Outdated Show resolved Hide resolved
src/cpl/nuopc/lnd_import_export.F90 Outdated Show resolved Hide resolved
@ekluzek ekluzek mentioned this pull request Mar 19, 2021
5 tasks
@ekluzek
Copy link
Collaborator

ekluzek commented Mar 19, 2021

@mvertens there are some tests where the length was changes from nine steps to twelve. The nine step tests were setup to match similar CAM tests. From what I can see those CAM tests were NOT changed. Is there a reason the tests were changed in length?

These tests will be changed in CAM with my upcoming PR.

Externals.cfg Outdated Show resolved Hide resolved
@mvertens
Copy link
Author

mvertens commented Mar 26, 2021 via email

@ekluzek
Copy link
Collaborator

ekluzek commented Mar 26, 2021

@mvertens ahh, I thought it might be that. I checked the tests in CAM and they change the ROF and GLC coupling frequency to enable doing 9-step tests. And they do a bunch of 9-step tests. Since these are meant to make sure the CAM tests work, I tend toward making them look the same as the CAM tests.

@billsacks billsacks mentioned this pull request Mar 26, 2021
9 tasks
@ekluzek
Copy link
Collaborator

ekluzek commented Mar 29, 2021

There are some more tests that fail because of missing mesh files. But, I think I have that all in hand and will be able to fix that.

But, there are two tests that are now failing consistently on izumi trying to read in all of the forcing files for time info. It fails consistently on the same TPQWL file.

SMS_Ld5_D_P48x1_Vnuopc.f10_f10_mg37.IHistClm51Bgc.izumi_nag.clm-decStart
SMS_P48x1_D_Ld5_Vnuopc.f10_f10_mg37.I2000Clm50Cn.izumi_nag.clm-default

For example the first one fails trying to read this file:

/project/tss/atm_forcing.datm7.GSWP3.0.5d.v1.c170516/TPHWL/clmforc.GSWP3.c2011.0.5x0.5.TPQWL.1901-03.nc

The cesm.log file looks like this...

[47] proc= 47 clump no = 1 clump id= 48 beg patch = 6064 end patch = 6183 total patches per clump = 120
[47] proc= 47 clump no = 1 clump id= 48 beg cohort = 249 end cohort = 253 total cohorts per clump = 5
[[email protected]] HYDT_bscd_pbs_wait_for_completion (tools/bootstrap/external/pbs_wait.c:67): tm_poll(obit_event) failed with TM error 17002
[[email protected]] HYDT_bsci_wait_for_completion (tools/bootstrap/src/bsci_wait.c:23): launcher returned error waiting for completion

@billsacks
Copy link
Member

@ekluzek are you trying to run the full test suite with --driver nuopc? If so, I think that can wait and shouldn't hold up this PR.

@ekluzek
Copy link
Collaborator

ekluzek commented Mar 30, 2021

Yes, what I did is I ran it that way before we setup the new tests. And I was just rerunning those tests with the updates we've brought in. I'm fine with not requiring these tests to work. But, I am concerned about them not passing for general use of NUOPC, especially because I don't get what's different about these tests and why they aren't working. So it is disconcerting that they aren't working. But, I'll mark them as expected fails for now.

@ekluzek ekluzek merged commit cb6057e into ESCOMP:master Mar 31, 2021
@ekluzek ekluzek deleted the mvertens/scolpr branch March 31, 2021 23:04
ekluzek added a commit to ekluzek/CTSM that referenced this pull request Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations
Projects
No open projects
4 participants