-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New single column functionality for NUOPC/CMEPS #1309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just flipped through this quickly (mostly leaving the review to @ekluzek ), but wanted to ask about a couple of changes I noticed.
@mvertens there are some tests where the length was changes from nine steps to twelve. The nine step tests were setup to match similar CAM tests. From what I can see those CAM tests were NOT changed. Is there a reason the tests were changed in length? These tests will be changed in CAM with my upcoming PR. |
…nts up, remove unneeded declaration of esmf_calander as this caused a problem on NAG on izumi
We need to have 12 time steps for both CAM and CLM. The reason is that you
need to have a multiple of the rof coupling interval - which is 3 hours -
unless you set the runoff coupling interval to be every time step. The
model will crash if it notices that the ending time step is in the middle
of a component coupling interval. So the tests must be 12 time steps.
…On Fri, Mar 19, 2021 at 3:10 PM Erik Kluzek ***@***.***> wrote:
@mvertens <https://github.com/mvertens> there are some tests where the
length was changes from nine steps to twelve. The nine step tests were
setup to match similar CAM tests. From what I can see those CAM tests were
NOT changed. Is there a reason the tests were changed in length?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1309 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4XCE66JW32TUGSNDBLWCDTEO4V5ANCNFSM4ZPHCOGA>
.
--
Mariana Vertenstein
CESM Software Engineering Group Head
National Center for Atmospheric Research
Boulder, Colorado
Office 303-497-1349
Email: ***@***.***
|
@mvertens ahh, I thought it might be that. I checked the tests in CAM and they change the ROF and GLC coupling frequency to enable doing 9-step tests. And they do a bunch of 9-step tests. Since these are meant to make sure the CAM tests work, I tend toward making them look the same as the CAM tests. |
There are some more tests that fail because of missing mesh files. But, I think I have that all in hand and will be able to fix that. But, there are two tests that are now failing consistently on izumi trying to read in all of the forcing files for time info. It fails consistently on the same TPQWL file. SMS_Ld5_D_P48x1_Vnuopc.f10_f10_mg37.IHistClm51Bgc.izumi_nag.clm-decStart For example the first one fails trying to read this file: /project/tss/atm_forcing.datm7.GSWP3.0.5d.v1.c170516/TPHWL/clmforc.GSWP3.c2011.0.5x0.5.TPQWL.1901-03.nc The cesm.log file looks like this...
|
@ekluzek are you trying to run the full test suite with |
Yes, what I did is I ran it that way before we setup the new tests. And I was just rerunning those tests with the updates we've brought in. I'm fine with not requiring these tests to work. But, I am concerned about them not passing for general use of NUOPC, especially because I don't get what's different about these tests and why they aren't working. So it is disconcerting that they aren't working. But, I'll mark them as expected fails for now. |
…ersion of the tests, and set ROF_NCPL to ATM_NCPL as is done in the CAM tests
Description of changes
New single column functionality for NUOPC/CMEPS
Specific notes
Implemented new nuopc/cmeps single column functionality.
In config/cesm/config_files.xml - single point domains are only used for mct/cpl7.
For cmeps single point meshes are now generated on the fly and component domains files are no longer needed.
env_run.xml variables PTS_LAT, PTS_LON and PTS_DOMAINFILE are used to determine if there is a single point or single column run.
If PTS_LAT and PTS_LON are not -999 and PTS_DOMAINFILE is UNSET, then you have a single point run and the exact values of PTS_LAT and PTS_LON are used.
If PTS_LAT and PTS_LON are not -999 and PTS_DOMAINFILE is not UNSET, then then the cmeps driver will recognize the nearest neighbor values of PTS_LAT and PTS_LON in PTS_DOMAINFILE as the single column lat and lon to use.
This PR only effects nuopc/cmeps configurations. New External entries are needed for CMEPS, CDEPS and CIME.
Contributors other than yourself, if any:
CTSM Issues Fixed:
Fixes #1312
Fixes #1302
Fixes #1183
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? New xml variables for NUOPC configurations
Testing performed, if any: Performed testing associated with doing a CMEPS/CDEPS PR.