-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid cell-level error check for H2O #1228
Merged
Merged
Changes from 10 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
654b53d
Grid cell-level error check for H2O: non-transient simulations only
slevis-lmwg 5a0c758
Deleted a blank line; committing this in prep for update to latest tag
slevis-lmwg 714ef19
Merge tag 'ctsm5.1.dev018' into gcell_bal_checks_h2o
slevis-lmwg ff59a5f
Mods required in new code from conflicts not caught by git
slevis-lmwg 78a979f
Move call BalanceCheck to after call lnd2atm; use existing _grc vars
slevis-lmwg 4ab9f3d
Some clean-up before moving on to solving the transient h2o balance
slevis-lmwg d267ceb
Mods for successful grid cell-level H2O error checks in transient cases
slevis-lmwg b636724
Merge tag 'ctsm5.1.dev019' into gcell_bal_checks_h2o
slevis-lmwg 32a7930
Minor clean-up
slevis-lmwg 097ff98
First draft of ChangeLog
slevis-lmwg cb6a840
Revisions part 1 in response to code review
slevis-lmwg 799e011
Revisions part 2: bypass `for_testing_zero_dynbal_fluxes` cases
slevis-lmwg 23bf38b
Revisions part 3: Insert comment about negative dribble terms
slevis-lmwg c5b0961
Addition of text to the comment that I added in the last commit
slevis-lmwg 6e38fc2
Revisions part 4: Tracking wa_reset_nonconservation_gain
slevis-lmwg 6f0bf37
Minor cleanup of comments and write statements
slevis-lmwg bf52b8a
Cleanup of comments, write-statmts, and formatting
slevis-lmwg 5dbbc81
Revisions 4b: Move code from the beg. to the ending of h2o balance check
slevis-lmwg 645e831
Merge tag 'ctsm5.1.dev021' into gcell_bal_checks_h2o
slevis-lmwg 910fa8b
Merge tag 'ctsm5.1.dev023' into gcell_bal_checks_h2o
slevis-lmwg 6768534
Bypass grc-level h2o check when use_soil_moisture_streams = .true.
slevis-lmwg 09e3553
Revisions required for I*G tests and *clm-prescribed tests to PASS
slevis-lmwg 5a0ba10
Small updates to ChangeLog and ChangeSum
slevis-lmwg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am realizing that I should have considered the rms diff (not the normalized diff), and I should remove the Xs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE