Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perturbed Parameter Experiment (PPE) branch #1199

Closed
wants to merge 385 commits into from
Closed

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Oct 29, 2020

Description of changes

This is the start of the branch for the Perturbed Parameter Experiment work. It includes the Arctic LUNA work with Kattge from @lmbirch, as well as work on more parameters from @olyson. It also will include the CN-Matrix and soil matrix solution work PR #640.

See many notes on the parameters that will be experimented with:

https://docs.google.com/spreadsheets/d/1OtkaO_uAmafWKR9kgtRC2Ge6d6fkhymngSpben5SJ_Q

Specific notes

Contributors other than yourself, if any: @lmbirch, @wwieder @olyson @djk2120

Many others are contributing to the simulation framework and scripting.

Are answers expected to change (and if so in what way)? Yes (ctsm5_1)

Any User Interface Changes (namelist or namelist defaults changes)? New params file

Testing performed, if any: The individual branches have had standard testing run on them.

Xingjie Lu and others added 30 commits October 6, 2019 00:51
…ying from array adding in otherwise accumulate as normal
…e it should already be set initially with a setValueCopySM command
Merge branch 'cn-matrix_v3' of https://github.com/chrislxj/ctsm into cn-matrix_v3
…dding a subroutine to copy indices and start adding a test for it
Start adding water tracers to LakeHydrology, and related refactoring

Start adding water tracers to LakeHydrology, beginning with some initial
things done for snow.

This also includes some significant refactoring to allow LakeHydrology
to reuse some of the same snow code used for non-lake columns.
src/soilbiogeochem/SoilBiogeochemCarbonFluxType.F90.

The 76f7d change appears to be correct, but it's causing Carbon
balance checks to fail, which must mean there must be other
changes that need to happen with this one.
…allow AD spinup mode and matrix spinup to be on at the same time, add some checks for this as well
…e array for vertical transfer (rather than adding it in as zeros)
…Update? subroutine, but the matrix equivalent is in another place in the code
Update to ctsm1.0.dev080.

 Conflicts:
	src/biogeochem/CNFireLi2014Mod.F90
	src/biogeochem/CNNStateUpdate3Mod.F90
	src/biogeochem/CNVegCarbonStateType.F90
	src/biogeochem/NutrientCompetitionCLM45defaultMod.F90
	src/main/clm_driver.F90
	src/main/clm_instMod.F90
	src/soilbiogeochem/SoilBiogeochemDecompCascadeBGCMod.F90
	src/soilbiogeochem/SoilBiogeochemDecompCascadeCNMod.F90
	src/utils/CMakeLists.txt
ekluzek and others added 20 commits January 25, 2024 14:24
Update the PPE with externals from the release-cesm2.2 branch so that it will work on Derecho
…2.2.03 and release-cesm2.2.04 changes come in
Backup the PPE branch to ctsm5.1.dev030, but working on Derecho
@slevis-lmwg slevis-lmwg self-assigned this Apr 11, 2024
@wwieder wwieder added this to the 2024 CESM June workshop milestone May 2, 2024
@wwieder
Copy link
Contributor

wwieder commented May 2, 2024

I've added this to the CESM Workshop milestone. How realistic do you think is this, @ekluzek and @slevis-lmwg ?

@slevis-lmwg
Copy link
Contributor

According to my notes from a meeting with @ekluzek:
I need to check in with @ekluzek before starting to work on this, so for me this is on hold.

@ekluzek ekluzek removed priority: high High priority to fix/merge soon, e.g., because it is a problem in important configurations PR status: work in progress labels Jun 20, 2024
@ekluzek
Copy link
Collaborator Author

ekluzek commented Jun 20, 2024

This is still out there, but in terms of it coming to master, it won't come in the current form. Most of it already has. But, #640 is on track to come in soon which is the biggest outstanding piece of this. There's also some small changes for PPE work outside of that that will come to master as a separate task defined in #2567.

The branch itself will stay in place. But, I'm closing the PR. The main point of having it as a PR was visibility for the PPE work. But, the PPE work has sufficient visibility at this point.

@ekluzek ekluzek closed this Jun 20, 2024
@samsrabin samsrabin added the science Enhancement to or bug impacting science label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science
Projects
Status: Ready to eat (Done!)
Development

Successfully merging this pull request may close these issues.

8 participants