Move mksurfdata_map rounding of special landunits to before wetland fill #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this may be important to avoid errors and/or wrong behavior in some edge cases where we have < 0.5% cover of glacier and/or lake, and other cases. See ESCOMP#1118 for detailed thoughts Resolves ESCOMP#1118
billsacks
added
the
PR status: ready
|
@ekluzek it seems like it would be good to use these diffs when you recreate all surface datasets. Would you like me to bring this in on its own? If so, are you comfortable with my testing including (a) the comparison of the three surface datasets f09, f19 and f10, plus (b) standard tools testing? (Or would you rather just fold this into your tag where you update surface datasets?) |
|
At @ekluzek 's request, I also compared 4x5 surface datasets with and without this change and they, too, are identical (from |
|
Tools tests all pass, with comparison against ctsm1.0.dev110 |
samsrabin
pushed a commit
to samsrabin/CTSM
that referenced
this pull request
Sep 17, 2024
user controlled history density
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
I think this may be important to avoid errors and/or wrong behavior in
some edge cases where we have < 0.5% cover of glacier and/or lake, and
other cases.
See #1118 for detailed thoughts
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Resolves #1118
Are answers expected to change (and if so in what way)? Possible answer changes, but this should be rare
Any User Interface Changes (namelist or namelist defaults changes)? N
Testing performed, if any:
I created a subset of our standard surface datasets with
make -f Makefile.data global-presentbefore and after this change. The three surface datasets created in this way (f09, f19 and f10) were all bit-for-bit. There could be answer changes in rare cases, but this demonstrates that I haven't majorly broken anything with this change.