Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the list of valid resolutions in namelist_definition #2179

Closed
ekluzek opened this issue Sep 29, 2023 · 0 comments
Closed

Remove the list of valid resolutions in namelist_definition #2179

ekluzek opened this issue Sep 29, 2023 · 0 comments
Assignees
Labels
code health improving internal code structure to make easier to maintain (sustainability)

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Sep 29, 2023

For mksurfdata_map and mksurfdata we needed a list of valid resolutions. The need for this goes way back before config_grids and query_config --grids was a thing.

It also has been problematic in the recent past because developers had to edit namelist_definition as well as ccs_config to add new grids. Removing this makes it easier for developers. This has also been a problem in #2008 because the list is so long. The other use of this list is in the build-namelist tester, but right now what it does is remove a long list of resolutions, when the list of valid resolutions to use would be shorter. So good for past and current time.

This also resolves #9 As we should remove both hgrid and res from namelist_definition.

@ekluzek ekluzek added the code health improving internal code structure to make easier to maintain (sustainability) label Sep 29, 2023
@ekluzek ekluzek self-assigned this Sep 29, 2023
@ekluzek ekluzek closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health improving internal code structure to make easier to maintain (sustainability)
Projects
None yet
Development

No branches or pull requests

1 participant