Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "successfully completed" message to mksurfdata_esmf when the landuse.timeseries file is made #2131

Closed
ekluzek opened this issue Aug 31, 2023 · 4 comments · Fixed by #2372
Assignees
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability
Milestone

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Aug 31, 2023

mksurfddata_esmf has a success message that gets printed out when the surface data is created, but not for the landuse.timeseries file. We should just add a message similar to that for the surfdata file.

  ! ----------------------------------------------------------------------
  ! Close surface dataset
  ! ----------------------------------------------------------------------
  if (fsurdat /= ' ') then
     call pio_closefile(pioid)
     if (root_task) then
        write(ndiag,*)
        write(ndiag,'(a)') 'Successfully created surface data output file = '//trim(fsurdat)
        write(ndiag,'(a)') '   This file contains the land model surface data'
        write(ndiag,*)
     end if
  end if

  ! ======================================================================
  ! Create fdyndat if appropriate
  ! ======================================================================

1000 continue

  if (mksrf_fdynuse /= ' ') then

.
.
.
.
    if (root_task)  write(ndiag, '(a,i8)') trim(subname)//" writing PCT_LAKE_MAX"
     call mkfile_output(pioid, mesh_model, 'PCT_LAKE_MAX', pctlak_max, rc=rc)
     if (ChkErr(rc,__LINE__,u_FILE_u)) call shr_sys_abort('error in calling mkfile_output for PCT_LAKE_MAX')

     if (num_cft > 0) then
        if (root_task)  write(ndiag, '(a,i8)') trim(subname)//" writing PCT_CFT_MAX"
        call get_pct_p2l_array(pctcft_max, ndim1=lsize_o, ndim2=num_cft, pct_p2l=pct_cft)
        call mkfile_output(pioid, mesh_model, 'PCT_CFT_MAX', pct_cft, rc=rc)
        if (ChkErr(rc,__LINE__,u_FILE_u)) call shr_sys_abort('error in calling mkfile_output for PCT_CFT')
     end if

     ! Close the file
     call pio_closefile(pioid)

  end if   ! end of if-create dynamic landust dataset
@ekluzek ekluzek added the enhancement new capability or improved behavior of existing capability label Aug 31, 2023
@ekluzek ekluzek added this to the ctsm5.2.0 milestone Aug 31, 2023
@ekluzek
Copy link
Collaborator Author

ekluzek commented Aug 31, 2023

@adamrher @slevis-lmwg

@ekluzek
Copy link
Collaborator Author

ekluzek commented Oct 6, 2023

We also need a successfully completed message for the gen_mksurfdata_jobscript_multi.py so you can tell if a set of jobs sent completed.

@slevis-lmwg
Copy link
Contributor

But are we keeping gen_mksurfdata_jobscript_multi.py or will your makefile work replace it @ekluzek ?

@ekluzek
Copy link
Collaborator Author

ekluzek commented Oct 6, 2023

We are keeping it, the Makefile, just sends jobs for particular cases using it.

ekluzek added a commit to ekluzek/CTSM that referenced this issue Oct 11, 2023
…rly abort, add success message on landuse.timeseries (Fixing ESCOMP#2131), read in namelist before MPI and ESMF initialize so can set default name for PET files, and split out namelist broadcast to a seperate call
@samsrabin samsrabin added simple bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants