-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c13/c14 isotope time-series is awkward for 1850 control (convert to streams file) #182
Comments
Erik Kluzek < erik > - 2017-11-10 16:16:48 -0700 This also means the default for 1850 and transient cases when use_c13/use_c14 are on should be to also turn on the time-series files for these cases. That'll do the right thing most of the time. |
Keith Lindsay < klindsay > - 2017-11-13 09:38:34 -0700 Erik, When I looked at using streams to handle the CMIP6 dataset, it looked to me like the shr code didn't handle the time units in the dataset. time:units in the dataset is "years since 1850-01-01 0:0:0.0", and shr_string_parseCFtunit in shr_string_mod.F90 has the comment Assuming I'm interpreting the above correctly, it seems like one of the following needs to happen:
Option 1) seemed unappealing to me because of the shr code's support for both no_leap and gregorian calendars. It seemed like it might be complicated to implement new functionality in shr code while not being consistent with the existing shr code. If you go the route of option 2), I'll need to modify POP's code that processes this dataset, assuming that we want to continue having CLM and POP read the same file for this forcing. Please let me know if decide to pursue this path. Keith |
Keith Lindsay < klindsay > - 2017-11-13 09:59:10 -0700 (In reply to Erik Kluzek from comment #1)
It sounds like this will lead to using the 1850 value for these forcings, in spinup runs, and in the 1850 control runs. The 1850 values (permil) of Delta14C in the CMIP6 dataset in the different latitude bands are Is that what we want to be using in our BGC spinups and in the 1850 control runs? I'm used to using 0 permil for PI spinups, though this does create a jump at 1850. I can see arguments for using 0 or for using the 1850 values. I definitely think we should use the same value in the spinups as in the 1850 control runs. I also think we should use the same values in CLM and in POP. Unfortunately, I don't see a specification for this in the C4MIP GMD paper, Jones et al. 2016. |
charlie < cdkoven > - 2017-11-13 10:11:23 -0700 Agreed with Keith that there are arguments for using either 0 or the PI values during spinup and PI controls. I suppose I'd vote for using the PI values, even though that's not what my original code does, in the interest of avoiding artificial discontinuities. |
Keith Lindsay < klindsay > - 2017-11-13 10:18:54 -0700 (In reply to Keith Lindsay from comment #2)
I meant "... while being consistent ...". |
David Lawrence < dlawren > - 2017-11-13 10:29:45 -0700 It makes more sense to me to use 1850 values for spinup and 1850 control. Question: if we were using zero per mil, then can you run with isotopes off during spinup and in the 1850 control? ... and only turn them on for the transient, thereby saving some computer time? In the end, I think the decision on what to do should come from Charlie and Keith since they have more experience with isotopes. |
charlie < cdkoven > - 2017-11-13 10:34:51 -0700 re Dave's Question: using zero or the PR value shouldn't really help either way for either isotope. For 14C, since the spinup problem is equilibration with respect to radioactive decay, you still have to do that (albeit in an accelerated way under AD). For 13C, the spinup problem there is with respect to isotopic fractionation, so, again, you still have to actually do it. The atmospheric value just becomes the boundary condition for the system in both cases, and in both cases you need to do the equilibration in AD mode in order to let it propagate rapidly through all the pools. |
Erik Kluzek < erik > - 2017-11-13 11:11:58 -0700 (In reply to Keith Lindsay from comment #2)
I looked into this as well. The meaning is a bit awkward for the Gregorian calendar. And because of this the CF contention warns against using a unit of years. But, it says you define the interval as 365 for no_leap or 365.2425 for Gregorian. So how exact the end result would be depends on the reference date. It wouldn't be hard to extend the code in cime/src/share/util/shr_string_mod to handle this. But, because of this issue we probably shouldn't. I'm bringing it up as an issue to CSEG, we'll see what feedback they have. Here's the caution in the CF convention... http://cfconventions.org/Data/cf-conventions/cf-conventions-1.7/build/ch04s04.html
|
Keith Lindsay < klindsay > - 2017-11-17 15:53:01 -0700 Regarding using 1850 values or 0 permil for 1850 control runs and spinup, I've sought input from Alex Jahn, who developed the C isotopes in POP, and Bette Otto-Bliesner and Esther Brady, as representatives of the paleo and isotope users. Everyone has either no preference or a slight preference for using 1850 values. So counting those three, Charlie and myself, no one has expressed a strong preference for using 0 permil. So I think we've reached a consensus to use the 1850 values. Note that this is independent of switching to shr code. I do not plan on changing POP to use shr code, unless the dataset's time:units is changed. I will change POP to use the 1850 values in 1850 controls and spinup runs. (This is a little quirky for 14C because of the latitude bands in the dataset, but that's the way it is.) |
Note, that this mechanism was inadvertently turned on in for 1850 control simulations. Since, the default is for 1850 conditions, it really didn't need to be. It only causes a problem if you run for more than 1850 years though. But, there were some simulations that ran for that long. |
I've worked on this more and I want to list the issues with the current implementation. The starting year (1850) is hardcoded in, as well as that the time units will be in years. The number of sectors is hardcoded, as are the width of the bands. It will die if the number of sectors is wrong, but won't detect a change in the latitude band width. The time unit of years is considered a bad unit, because you can't detect a difference between Gregorian or no-leap calendars (like you can for other units). It does check the units, so will die if the starting year is wrong, or time isn't years, or the wrong units are used for C13 or C14. So that's good. But, the user also has no control over what years are used in the file, nor spatial nor temporal interpolation. All of these things come out of the box with a streams implementation. And it's trusted shared code, rather than custom code, so better from a maintenance standpoint. The streams implementation will automatically adjust to changes in both the temporal and spatial description of the file. The current mechanism also can't choose the time-period, which means the same file can't be used for Modern as for 20th Century. And as already shown this implementation has #592. |
One other problem (with the current dataset not necessarily in the code itself) is that you can't do ncview on the file: $DIN_LOC_ROOT/lnd/clm2/isotopes/atm_delta_C14_CMIP6_3x1_global_1850-2015_yearly_v2.0_c171012.nc. This is because of the metadata on the "sector" variable is incorrect for CF. Using flag_* attributes allows you to view the file in ncview. |
Blocks #592 |
7b6d92ef6 Merge pull request #198 from johnpaulalex/gitdir 927ce3a98 Merge pull request #197 from johnpaulalex/testpath a04f1148f Merge pull request #196 from johnpaulalex/readmod d9c14bf25 Change the rest of the methods to use -C. Still some usage of getcwd in test_unit_repository_git. 332b10640 Fix incorrect logged path of checkout_externals in test_sys_checkout: it was basically the parent of the current directory, which varies throughout the test. (it called abspath with '{0}/../../', which adds arbitrary and not-interpolated subdir '{0}' to the path, then removes it and removes one more level). 932a7499b Remove printlog from read_gitmodules_file since read_externals_description_file() already has a nearly-the-same printlog (but add it to the other caller). 5d13719ed Merge pull request #195 from johnpaulalex/check_repo 423395449 Update utest to mock _git_remote_verbose in a new way, since it is now called via the GitRepository class rather than on the specific GitRepository instance. d7a42ae96 Check that desired repo was actually checked out. 71596bbc1 Merge pull request #194 from johnpaulalex/manic2 4c96e824e Make the MANIC_TEST_BARE_REPO_ROOT env var special - give it a constant for easy tracking, and automatically tear it down after each test. 259bfc04d test_sys_checkout: use actual paths in on-the-fly configs rather than MANIC_TEST_BARE_REPO_ROOT env var. This will make it easier to test (in the near future) that checkout_externals actually checked out the desired repo dir. 557bbd6eb Merge pull request #193 from johnpaulalex/manic 5314eede1 Remove MANIC_TEST_TMP_REPO_ROOT environment variable in favor of module-level variable. 345fc1e14 Merge pull request #191 from johnpaulalex/test_doc12 2117b843c test_sys_checkout: verify that basic by-tag/branch/hash tests actually take us to the correct git tag/branch/hash. 94d6e5f2b Merge pull request #190 from johnpaulalex/test_doc11 3ff33a6a8 Inline local-path-creation methods 47dea7f64 Merge pull request #189 from johnpaulalex/test_doc10 9ea75cbf8 Grab-bag of renamings: Remove redundant _NAME from repo constants, and consistently add _REPO suffix (This causes the majority of diffs). c0c847ec8 Merge pull request #188 from johnpaulalex/test_doc9 2dd5ce0f7 test_sys_checkout.py: only check for correct 'required' or 'optional' state in the test that exercises required vs optional behavior. Removed a lot of boilerplate. eb3085984 Merge pull request #187 from johnpaulalex/test_doc8 1832e1f84 test_sys_checkout: Simplify many tests to only use a single external. 8689d61ec Merge pull request #186 from johnpaulalex/test_doc7 fbee4253e Grab bag of test_sys_checkout cleanups: Doc inside of each test more clearly/consistently. TestSysCheckoutSVN didn’t get the inlining-of-helper-methods treatment, now it has that. Move various standalone repo helper methods (like create_branch) into a RepoUtils class. README.md was missing newlines when rendered as markdown. Doc the return value of checkout.main Fix test_container_exclude_component - it was looking for the wrong key (which is never present); now it looks for the correct key. f0ed44a6e Merge pull request #185 from johnpaulalex/test_doc6 a3d59f5f2 Merge pull request #184 from johnpaulalex/test_doc5 5329c8ba7 test_sys_checkout: Inline config generation functions that are only called once. 464f2c7a7 test_sys_checkout: Inline another layer (per-config-file checks). Rename the 4 methods that are used multiple times, to reflect what they do rather than what they're called. 8872c0df6 Merge pull request #183 from johnpaulalex/doc_test4 c045335f6 Merge pull request #182 from johnpaulalex/doc_test3 c583b956e Merge pull request #181 from johnpaulalex/doc_test2 e01cfe278 test_sys_checkout: less confusing handling of return values from checkout_externals. Specifically, when doing a checkout, don't return tree_status from _before_ the checkout. Make a new wrapper to call checkout_externals a second time, to calculate the new status after a checkout (very frequent pattern). 23286818c test_sys_checkout: Remove another layer (which generates test component names) c3717b6bc Merge pull request #180 from johnpaulalex/doc_test 36d7a4434 test_sys_checkout.py: remove one layer of functions (that check for local status enums). No-op. 2c4584bf7 More documentation about tests: * contents of test repositories (n a new README.md) * various constants in test_sys_checkout.py that point to those contents, and terminology like container/simple/mixed. * in each test method, the scenarios being tested. * The coupling between test methods. 55e74bd0a Merge pull request #179 from johnpaulalex/circ 66be84290 Remove circular dependency by making _External stop doing tricky things with sourcetrees. git-subtree-dir: manage_externals git-subtree-split: 7b6d92ef689e2f65733e27f8635ab91fb341356b
0f884bfec Merge pull request #205 from jedwards4b/sunset_svn_git_access 82a5edf79 merge in billsacks:svn_testing_no_github 17532c160 Use a local svn repo for testing 9c904341a different method to determine if in tests 539952ebd remove debug print statement cc5434fa7 fix submodule testing 1d7f28840 remove broken tests 04e94a519 provide a meaningful error message 38bcc0a8c Merge pull request #201 from jedwards4b/partial_match b4466a5aa remove debug print statement c3cf3ec35 fix issue with partial branch match 7b6d92ef6 Merge pull request #198 from johnpaulalex/gitdir 927ce3a98 Merge pull request #197 from johnpaulalex/testpath a04f1148f Merge pull request #196 from johnpaulalex/readmod d9c14bf25 Change the rest of the methods to use -C. Still some usage of getcwd in test_unit_repository_git. 332b10640 Fix incorrect logged path of checkout_externals in test_sys_checkout: it was basically the parent of the current directory, which varies throughout the test. (it called abspath with '{0}/../../', which adds arbitrary and not-interpolated subdir '{0}' to the path, then removes it and removes one more level). 932a7499b Remove printlog from read_gitmodules_file since read_externals_description_file() already has a nearly-the-same printlog (but add it to the other caller). 5d13719ed Merge pull request #195 from johnpaulalex/check_repo 423395449 Update utest to mock _git_remote_verbose in a new way, since it is now called via the GitRepository class rather than on the specific GitRepository instance. d7a42ae96 Check that desired repo was actually checked out. 71596bbc1 Merge pull request #194 from johnpaulalex/manic2 4c96e824e Make the MANIC_TEST_BARE_REPO_ROOT env var special - give it a constant for easy tracking, and automatically tear it down after each test. 259bfc04d test_sys_checkout: use actual paths in on-the-fly configs rather than MANIC_TEST_BARE_REPO_ROOT env var. This will make it easier to test (in the near future) that checkout_externals actually checked out the desired repo dir. 557bbd6eb Merge pull request #193 from johnpaulalex/manic 5314eede1 Remove MANIC_TEST_TMP_REPO_ROOT environment variable in favor of module-level variable. 345fc1e14 Merge pull request #191 from johnpaulalex/test_doc12 2117b843c test_sys_checkout: verify that basic by-tag/branch/hash tests actually take us to the correct git tag/branch/hash. 94d6e5f2b Merge pull request #190 from johnpaulalex/test_doc11 3ff33a6a8 Inline local-path-creation methods 47dea7f64 Merge pull request #189 from johnpaulalex/test_doc10 9ea75cbf8 Grab-bag of renamings: Remove redundant _NAME from repo constants, and consistently add _REPO suffix (This causes the majority of diffs). c0c847ec8 Merge pull request #188 from johnpaulalex/test_doc9 2dd5ce0f7 test_sys_checkout.py: only check for correct 'required' or 'optional' state in the test that exercises required vs optional behavior. Removed a lot of boilerplate. eb3085984 Merge pull request #187 from johnpaulalex/test_doc8 1832e1f84 test_sys_checkout: Simplify many tests to only use a single external. 8689d61ec Merge pull request #186 from johnpaulalex/test_doc7 fbee4253e Grab bag of test_sys_checkout cleanups: Doc inside of each test more clearly/consistently. TestSysCheckoutSVN didn’t get the inlining-of-helper-methods treatment, now it has that. Move various standalone repo helper methods (like create_branch) into a RepoUtils class. README.md was missing newlines when rendered as markdown. Doc the return value of checkout.main Fix test_container_exclude_component - it was looking for the wrong key (which is never present); now it looks for the correct key. f0ed44a6e Merge pull request #185 from johnpaulalex/test_doc6 a3d59f5f2 Merge pull request #184 from johnpaulalex/test_doc5 5329c8ba7 test_sys_checkout: Inline config generation functions that are only called once. 464f2c7a7 test_sys_checkout: Inline another layer (per-config-file checks). Rename the 4 methods that are used multiple times, to reflect what they do rather than what they're called. 8872c0df6 Merge pull request #183 from johnpaulalex/doc_test4 c045335f6 Merge pull request #182 from johnpaulalex/doc_test3 c583b956e Merge pull request #181 from johnpaulalex/doc_test2 e01cfe278 test_sys_checkout: less confusing handling of return values from checkout_externals. Specifically, when doing a checkout, don't return tree_status from _before_ the checkout. Make a new wrapper to call checkout_externals a second time, to calculate the new status after a checkout (very frequent pattern). 23286818c test_sys_checkout: Remove another layer (which generates test component names) c3717b6bc Merge pull request #180 from johnpaulalex/doc_test 36d7a4434 test_sys_checkout.py: remove one layer of functions (that check for local status enums). No-op. 2c4584bf7 More documentation about tests: * contents of test repositories (n a new README.md) * various constants in test_sys_checkout.py that point to those contents, and terminology like container/simple/mixed. * in each test method, the scenarios being tested. * The coupling between test methods. 55e74bd0a Merge pull request #179 from johnpaulalex/circ 66be84290 Remove circular dependency by making _External stop doing tricky things with sourcetrees. 82d3b247f Merge pull request #178 from johnpaulalex/test_doc 3223f49ea Additional documentation of system tests - global variables, method descriptions. 45b7c01c3 Merge pull request #177 from jedwards4b/git_workflow ace90b2c2 try setting credentials this way f4d6aa933 try setting credentials this way 1d61a6944 use this to set git credentials 7f9d330e1 use this to set git credentials 5ac731b85 add tmate code 836847be7 get git workflow working dcd462d71 Merge pull request #176 from jedwards4b/add_github_testing 2d2479e9d Merge pull request #175 from johnpaulalex/fix 711a53fdf add github testing of prs and automatic tagging of main cfe0f888a fix typos 5665d6140 Fix broken checkout behavior introduced by PR #172. 27909e255 Merge pull request #173 from johnpaulalex/readall 00ad0440b Further tiny refactorings and docs of checkout API (no-op). Remove unused load_all param in _External.checkout(). Rename _External.checkout_externals() to checkout_subexternals(), to remove the ambiguity about whether the main external pointed to by the _External is itelf checked out (it is not) Clarify load_all documentation - it’s always recursive, but applies different criteria at each level. Rename variables in checkout.py (e.g. ext_description) to match the equivalent code in sourcetree.py. 2ea3d1a3a Merge pull request #172 from johnpaulalex/fixit 43bf8092c Merge pull request #171 from johnpaulalex/docstatus e6aa7d21e Merge pull request #170 from johnpaulalex/printdir adbd71557 On checkout, refresh locally installed optional packages regardless of whether -o is passed in. add074593 Comment tweaks, and fix 'ppath' typo 696527cb8 Document the format of various status dictionaries, and the various paths and path components within an _External. c677b9403 When processing an external, print out its path in addition to the base filename (to disambiguate all the externals.cfg's) 975d7fd5a Merge pull request #169 from johnpaulalex/docfix_branch 09709e36d Document _Externals.status(). The original comment was apparently copy-pasted from checkout(). 1d880e090 Merge pull request #167 from billsacks/fix_svn_on_windows 3510da848 Tweak a unit test to improve coverage eb7fc1368 Handle the possibility that the URL already ends with '/' 02ea87e3d Fix svn URLs on Windows b1c02ab54 Merge pull request #165 from gold2718/doc_fix 9f4be8c7b Add documentation about externals = None feature a3b3a0373 Merge pull request #162 from ESMCI/fischer/python3 d4f1b1e8d Change shebang lines to python3 2fd941abc Merge pull request #158 from billsacks/modified_solution de08dc2ee Add another option for when an external is in a modified state e954582d0 Merge pull request #156 from billsacks/onbranch_show_hash 952e44d51 Change output: put tag/hash before branch name 10288430f Fix pre-existing pylint issues 01b13f78f When on a branch, show tag/hash, too 39ad53263 Merge pull request #150 from gold2718/fix_combo_config 75f8f02f5 Merge pull request #152 from jedwards4b/sort_by_local_path 42687bd53 remove commented code 29e26af81 fix pylint issues 7c9f3c613 add a test for nested repo checkout 75c5353d2 fix spacing 24a3726a1 improve sorting, checkout externals with each comp 29f45b086 remove py2 test and fix super call 880a4e765 remove decode 1c53be854 no need for set call 36c56dbac simplier fix for issue dc67cc682 simpler solution b32c6fca9 fix to allow submodule name different from path 5b5e1c2b0 Merge pull request #144 from billsacks/improve_errmsg c983863c4 Add another option for dealing with modified externals 59ce252cf Add some details to the error message when externals are modified be5a1a4d7 Merge pull request #143 from jedwards4b/add_exclude 2aa014a1b fix lint issue 49cd5e890 fix lint issues 418173ffd Added tests for ExternalsDescriptionDict afab352c8 fix lint issue be85b7d1b fix the test a580a570b push test d43710864 add a test 21affe33c fix formatting issue 72e6b64ae add an exclude option git-subtree-dir: manage_externals git-subtree-split: 0f884bfec8e43d0c02261de858d6ec3f6d855e51
Erik Kluzek < erik > - 2017-11-10 16:15:08 -0700
Bugzilla Id: 2533
Bugzilla CC: cdkoven, dlawren, klindsay, rfisher,
Currently if you do a 1850 control, the assumed c13/c14 is for present day (delta of 0). You can get around this by asking for the c13/c14 time-series files, and if your start year is 0001, it'll use the 1850 value from the file. It's a little awkward since if you run a control for more than one thousand eight hundred and fifty years, it'll start running through the time-series file. For future scenarios it'll use the last value in the file, which is the most reasonable thing to do.
I think the best way around it, is to change the handling of this file from custom code to using the streams mechanism. This will actually shorten the amount of code needed in CLM as well as give more control, options, and flexibility in it's handling. The control for how the data was handled would be in the namelist for it and more obvious.
I think the sectors can be handled in streams by just representing them as three grid cells. This would also move the description of the data from baked inside the code to an outside grid file that could be changed with new datasets.
The text was updated successfully, but these errors were encountered: