Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative runoff fluxes in CESM3 Development Simulations #1816

Closed
olyson opened this issue Jul 21, 2022 · 34 comments
Closed

Negative runoff fluxes in CESM3 Development Simulations #1816

olyson opened this issue Jul 21, 2022 · 34 comments

Comments

@olyson
Copy link
Contributor

olyson commented Jul 21, 2022

In the CESM co-chairs meeting of 7/19/22, the OMWG noted that there were significant negative runoff fluxes in several of the recent CESM3 development coupled simulations, in particular, around several small islands.
We of course have had negative runoff fluxes in previous versions of the model (e.g., CESM2), due to irrigation and lakes (negative P-E).
However, these particular islands have neither irrigation nor lakes.
After a bit of analysis and discussion (@olyson @swensosc @wwieder ), we found that there are non-zero land fractions (identified by landfrac on the CLM history file) for gridcells where we don't have any surface data (pfts, lakes, glaciers, urban, crop) on the surface dataset being used. These are being modeled as wetlands which can have negative P-E and therefore negative runoff.
Several of these islands did not exist in CESM2.
For CESM3, there seems to be a bit of a mismatch between the landfrac that CLM actually uses (generated from the mesh file?) and the land/ocean mask on the surface dataset.
Question: Does this go away when we generate new surface datasets or will there always potentially be some kind of a mismatch?
@wwieder @swensosc @ekluzek @billsacks @dlawrenncar

@olyson olyson added type: -discussion next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Jul 21, 2022
@billsacks
Copy link
Member

This could change somewhat with newer raw data, but this issue will potentially always exist given our current method for generating surface datasets. Basically: if some area is outside the ocean model grid then CTSM becomes the owner of that area; if none of CTSM's raw datasets claim ownership of that area, then it is set as wetland. (Though note that we're currently doing this slightly wrong - see #1716 .)

If this negative runoff is a problem we will need to either (1) come up with a different scheme for what to do when CTSM owns an area that appears to be ocean according to CTSM's raw data sets; (2) change the physics in some way to avoid generating negative runoff.

@wwieder
Copy link
Contributor

wwieder commented Jul 22, 2022

Thanks for looking into this @olyson.
@billsacks I agree with your suggested solutions, which of these seem like the best option?For option_2 @swensosc suggested we could consider creating desert (bare ground) islands instead of wetland islands, which should avoid negative runoff.

@billsacks
Copy link
Member

I'm not sure off-hand. For changing what we call these areas (wetland vs. desert, etc.), I'm worried that solving one problem will create another – like treating substantial areas as bare land that should really be water. Changing the physics to avoid negative runoff sounds like a good idea, but I think could pose some real challenges. Regardless of what we do, I feel like it's going to be hard to avoid having some situations where we generate persistently negative (P-E), and it's hard for me to envision a good solution that avoids relying on the ocean to solve the problem.

@olyson
Copy link
Contributor Author

olyson commented Jul 27, 2022

We asked Cecile to run a short fully coupled simulation similar to one of the CESM3-dev simulations (b.cesm3_cam058_mom_c.B1850WscMOM.f09_L58_t061.011) to see what the effects are of taking the negative runoff directly from the river mouths.
This was accomplished by setting bypass_routing_option='direct_to_outlet' and qgwl_runoff_option='negative' in the mosart namelist.
Four years of this new simulation have been completed (b.cesm3_cam058_mom_c.B1850WscMOM.f09_L58_t061.015).
Results are shown in slides 7 and 8 of this slide deck:

https://docs.google.com/presentation/d/1gEK5ASR3CNbQPkdCCPm6SIavPjX7BCYh/edit?usp=sharing&ouid=104026900087612515425&rtpof=true&sd=true

Slide 7 shows that TOTAL_DISCHARGE_TO_OCEAN_LIQ is now positive everywhere in the new simulation (015) unlike in the control (011).
Slide 8 (monthly minimum of the lrunoff field from MOM) shows that there are very few ocean grid cells that have negative runoff in 015. Note the scale for 015 is two orders of magnitude smaller than 011.

There are standard diagnostics here:

https://webext.cgd.ucar.edu/B1850/b.cesm3_cam058_mom_c.B1850WscMOM.f09_L58_t061.015/lnd/b.cesm3_cam058_mom_c.B1850WscMOM.f09_L58_t061.015.2_4-b.cesm3_cam058_mom_c.B1850WscMOM.f09_L58_t061.011.2_4/setsIndex.html

In particular, set7 is of interest. The variability in these coupled simulations is probably swamping the effects of this change, particularly since these are only 3 year averages, but I don't see anything alarming in the results for discharge of individual rivers or into the individual ocean basins.

@olyson
Copy link
Contributor Author

olyson commented Jul 27, 2022

There are BUDGET WARNINGs in the mosart log file. For tracer 1 which I assume is liquid water.

/glade/scratch/hannay/archive/b.cesm3_cam058_mom_c.B1850WscMOM.f09_L58_t061.015/logs/rof.log.5167742.chadmin1.ib0.cheyenne.ucar.edu.220726-082955.gz

@billsacks billsacks removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jul 28, 2022
@olyson
Copy link
Contributor Author

olyson commented Aug 22, 2022

Sean has fixed a couple of bugs in the MOSART code with respect to the BUDGET WARNINGs we encountered when we set bypass_routing_option='direct_to_outlet' and qgwl_runoff_option='negative' in the mosart namelist.
I ran a pair of land-only simulations, one a control (with bypass_routing_option set to the default value of 'direct_in_place') and one with 'direct_to_outlet'. There are now no warnings in the log files.
Slide 3 of the slide deck shows the effect of this on reducing the negative TOTAL_DISCHARGE_TO_OCEAN_LIQ. What remains is due to, "For example, for the caspian, those gridcells don't have an outlet on the ocean mask. And the little dots in the continental interiors I think are 'sink' points, which don't touch the ocean. So we would still have negative runoff at those locations that is too large to be compensated for by the rivers. it would get passed to the ocean at those locations just like the direct_in_place method."

https://docs.google.com/presentation/d/1gEK5ASR3CNbQPkdCCPm6SIavPjX7BCYh/edit?usp=sharing&ouid=104026900087612515425&rtpof=true&sd=true

I don't see any discernable impact on our set7 discharge to the ocean diagnostics as shown here:

https://webext.cgd.ucar.edu/I2000/ctsm51_ctsm51d100_1deg_GSWP3V1_directtooutlet_2000/lnd/ctsm51_ctsm51d100_1deg_GSWP3V1_directtooutlet_2000.6_10-ctsm51_ctsm51d100_1deg_GSWP3V1_2000.6_10/set7/set7.html

I'm going to work on quantifying the magnitude of negative runoff with respect to total runoff and the reduction we get using this method.

@ekluzek
Copy link
Collaborator

ekluzek commented Aug 22, 2022

Adding @nmizukami to this issue as we will want to be aware of these issues in mizuRoute. We should for example make sure we implement direct_to_outlet in mizuRoute because of this issue. So direct_in_place and direct_to_outlet for bypass_routing_option should both be implemented in mizuRoute. And any fixes we need to put in place in MOSART we'll also want to get into mizuRoute.

@ekluzek
Copy link
Collaborator

ekluzek commented Aug 22, 2022

@olyson do you have a branch of MOSART with these changes? We should get these into a PR for MOSART. You could start the PR even before we are done with it's evaluation.

@billsacks
Copy link
Member

Thanks @olyson and @swensosc . My understanding is that we still want to move ahead with trying the replacement of wetlands with bare ground in addition to this MOSART fix; is that right? If so, I'll work on it today.

@olyson
Copy link
Contributor Author

olyson commented Aug 22, 2022

Yes, that is my understanding as well, thanks.

@wwieder
Copy link
Contributor

wwieder commented Aug 22, 2022

Yes, that would be great, @billsacks, as Sean's mosart changes don't help with the negative runoff from wetland islands.

@olyson, I recall you saying last week that frozen runoff in the log files was different with 'direct_to_outlet' option. Is this something we should investigate?

@olyson
Copy link
Contributor Author

olyson commented Aug 22, 2022

Yes, definitely should understand that.
Another thing is that in the land-only simulations, global negative runoff was reduced by about 70% (from -7.2e6 m3/s to -2.2e6 m3/s), but I don't see that reflected in the global sum of TOTAL_DISCHARGE_TO_OCEAN_LIQ. There is a difference between the two simulations, but the difference is quite small. Looking at the spatial map of the difference field there are a significant number of grid cells that have an increase in TOTAL_DISCHARGE_TO_OCEAN_LIQ which are apparently offsetting the decreases I would expect to see. I guess I would not expect to see any gridcells like that @swensosc ?

@swensosc
Copy link
Contributor

swensosc commented Aug 22, 2022 via email

@olyson
Copy link
Contributor Author

olyson commented Aug 22, 2022

Ok, I think this is fine actually. We would expect the global sum of TOTAL_DISCHARGE_TO_OCEAN_LIQ to be conserved.
I'm running a 'negative' option simulation anyway.

@olyson
Copy link
Contributor Author

olyson commented Aug 23, 2022

I don't see any significant differences with the 'negative' option combined with 'direct_in_place'.

@billsacks
Copy link
Member

The question I raised in the co-chairs meeting was about the many inland grid cells that showed negative discharge to ocean in the MOSART history files. My interpretation was that discharge to ocean in these inland cells would only arise from negative contributions, because any positive runoff would be routed to the ocean and so would show up in coastal grid cells. The alternative is that there really are a huge number of grid cells with a negative net runoff over the year, which would be very surprising to me.

@swensosc
Copy link
Contributor

swensosc commented Aug 23, 2022 via email

@billsacks
Copy link
Member

Thanks, @swensosc, that helps somewhat. However, the figure in question shows large swaths of area with negative runoff - see below. It seems unexpected to me that all of these grid cells would have net negative runoff - or that all of these points would be "sink" points.

image

@swensosc
Copy link
Contributor

swensosc commented Aug 23, 2022 via email

@dlawrenncar
Copy link
Contributor

dlawrenncar commented Aug 23, 2022 via email

@swensosc
Copy link
Contributor

swensosc commented Aug 23, 2022 via email

@dlawrenncar
Copy link
Contributor

dlawrenncar commented Aug 23, 2022 via email

@olyson
Copy link
Contributor Author

olyson commented Aug 23, 2022

I'm curious how mosart is able to split negative from positive runoff. Does it get passed the gridcell average runoff but in component form (surface, drainage, qrgwl, etc.) and then checks for negative runoff from each component at each time step?

@swensosc
Copy link
Contributor

swensosc commented Aug 23, 2022 via email

@olyson
Copy link
Contributor Author

olyson commented Aug 23, 2022

Ha, yes, I just read the manual. Point taken :)

@billsacks
Copy link
Member

Thanks for all this info. I'm still having trouble discerning the short answer to the question. I think what you're saying supports my original feeling that this figure does NOT imply net negative runoff from all of these grid cells, but I'm not sure....

@olyson
Copy link
Contributor Author

olyson commented Aug 24, 2022

MOSART PR issued (ESCOMP/MOSART#57) per @ekluzek request.

@olyson
Copy link
Contributor Author

olyson commented Aug 24, 2022

Regarding the issue I brought up with frozen runoff in the coupler log files (as shown in the last slide of the negative runoff ppt), I ran a clone of the fully coupled direct_to_outlet simulation with Sean's bug fix and that problem appears to be fixed as well. The frozen runoff from the lnd is showing up in the ocn column rather than the rof column as is normal.

@wwieder
Copy link
Contributor

wwieder commented Aug 24, 2022

thanks for checking this, Keith.

I still wonder if we addressed @billsacks question on negative net runoff fluxes from amazonian grid cells that we started discussing at co-chairs?

@olyson
Copy link
Contributor Author

olyson commented Aug 26, 2022

I tested the wetland fix in a land-only combined with direct_to_outlet. Seems to work, there are no longer any wetland areas. Negative runoff is only reduced by another 1% or so, there isn't that much negative runoff associated with wetlands globally. The problematic islands don't seem to have negative runoff anymore, at least in a monthly sense.

My understanding now based on our conversation is that the above figure does NOT imply net negative runoff from all of these grid cells.

@wwieder
Copy link
Contributor

wwieder commented Aug 26, 2022

Thanks for working on this Keith.

  • Are there appreciable changes in energy or water fluxes around our new beachy islands (or coasts)?
  • Are there any relevant updates for co-chairs, beyond "we fixed another tiny fraction of negative runoff"
  • Do we need to think about anything else before discussing at the CLM meeting next Thursday?

@wwieder
Copy link
Contributor

wwieder commented Aug 26, 2022

@billsacks and @ekluzek is this a good issue that should be converted to a discussion?

@billsacks
Copy link
Member

is this a good issue that should be converted to a discussion?

Sure.

@ekluzek
Copy link
Collaborator

ekluzek commented Aug 26, 2022

@wwieder I think it should. I just wanted to check before hand. I'll go ahead and do that.

@ESCOMP ESCOMP locked and limited conversation to collaborators Aug 26, 2022
@ekluzek ekluzek converted this issue into discussion #1835 Aug 26, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants