Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change FATES to run with use_nitrif_dentrif TRUE #1465

Closed
ekluzek opened this issue Aug 19, 2021 · 2 comments · Fixed by #1497
Closed

Change FATES to run with use_nitrif_dentrif TRUE #1465

ekluzek opened this issue Aug 19, 2021 · 2 comments · Fixed by #1497
Assignees
@ekluzek
Labels
enhancement new capability or improved behavior of existing capability

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Aug 19, 2021

By default FATES is being run with use_nitrif_dentrif=FALSE, we'd like to change this so that use_nitrif_dentrif is hardcoded to true (see #1356). This does mean answers will change for FATES cases.

@rgknox @ckoven @rosiealice do you need to do any testing to ensure that FATES simulations are fine to run with use_nitrif_dentrif to TRUE?
@ekluzek ekluzek added the enhancement new capability or improved behavior of existing capability label Aug 19, 2021
@ekluzek ekluzek self-assigned this Aug 19, 2021
@ckoven
Copy link
Contributor

ckoven commented Aug 19, 2021

@ekluzek it shouldn't matter, since we haven't been using FATES with the N cycle yet. So yes it should be fine.

@rgknox
Copy link
Collaborator

rgknox commented Aug 20, 2021

agreed

ekluzek added a commit to ekluzek/CTSM that referenced this issue Sep 23, 2021
@ekluzek
Change defaults for use_lch4 and use_nitrif_denitrif to be false if s…
1e2729f 
…oil_decomp_method is None, and otherwise TRUE which means it will normally be true when FATES is on fixing ESCOMP#1465
@ekluzek ekluzek mentioned this issue Sep 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ekluzek ekluzek

Labels
enhancement new capability or improved behavior of existing capability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Miscellaneous small answer changes ekluzek/CTSM
3 participants
@rgknox @ckoven @ekluzek