Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cprnc.pl and cprnc.ncl; use standard cprnc instead #14

Closed
billsacks opened this issue Dec 16, 2017 · 1 comment
Closed

remove cprnc.pl and cprnc.ncl; use standard cprnc instead #14

billsacks opened this issue Dec 16, 2017 · 1 comment
Labels
enhancement new capability or improved behavior of existing capability
Milestone

Comments

@billsacks
Copy link
Member

Bill Sacks < [email protected] > - 2013-05-29 12:59:52 -0600
Bugzilla Id: 1716
Bugzilla CC: [email protected], [email protected],

My understanding is that cprnc.ncl and its cprnc.pl wrapper exist only because the standard fortran-based cprnc wasn't able to compare files without a time dimension. As of cprnc_130529, this is fixed. So I propose removing these CLM-specific cprnc scripts, and switching testing to use the standard cprnc instead.

Advantages:

(1) no longer need to maintain these scripts

(2) I recently found a problem with the cprnc.ncl script - it doesn't flag files as different if they differ in where there are missing values (see bug 1714). The fortran-based cprnc handles this correctly

(3) The fortran-based cprnc gives you more information about differences than you can get from cprnc.ncl.

(4) Post-processing scripts that look at cprnc output (e.g., summarize_cprnc_diffs) don't work on cprnc.ncl output; so if we switch to using the fortran-based program, these post-processing scripts can be used.

@billsacks billsacks added this to the future milestone Dec 16, 2017
@billsacks billsacks added the enhancement new capability or improved behavior of existing capability label Dec 16, 2017
@ekluzek
Copy link
Collaborator

ekluzek commented May 17, 2018

We've done this, so closing.

@ekluzek ekluzek closed this as completed May 17, 2018
billsacks pushed a commit to billsacks/ctsm that referenced this issue Nov 19, 2019
Fix accumulators and add design document
MiCurry pushed a commit to MiCurry/CTSM that referenced this issue Sep 16, 2021
pts_mode bug fix - CICE_DECOMPTYPE overwritten
slevis-lmwg referenced this issue in slevis-lmwg/ctsm Dec 22, 2022
slevis-lmwg referenced this issue in slevis-lmwg/ctsm Aug 1, 2023
mvertens pushed a commit to mvertens/ctsm that referenced this issue Dec 8, 2023
adding information about the branches in NorESMhub/CTSM repository
jedwards4b added a commit to jedwards4b/ctsm that referenced this issue Feb 6, 2024
ac3e6dd Bump to 0.6.2
612fa61 Merge pull request ESCOMP#13 from jedwards4b/add_fxhash
cd74fd7 Merge pull request ESCOMP#14 from jedwards4b/fix/dir_path
459ee47 merge to main
f456ca0 fix issue with sparse checkout dir path
ad0a976 add support for fxhash variable in .gitmodules

git-subtree-dir: .lib/git-fleximod
git-subtree-split: ac3e6dd
jedwards4b added a commit to jedwards4b/ctsm that referenced this issue Jun 2, 2024
fix issue with sparse checkout dir path
ekluzek added a commit to ekluzek/CTSM that referenced this issue Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability
Projects
None yet
Development

No branches or pull requests

2 participants