Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

360x720 mapping directory name disagrees with resolution name #10

Closed
billsacks opened this issue Dec 16, 2017 · 5 comments
Closed

360x720 mapping directory name disagrees with resolution name #10

billsacks opened this issue Dec 16, 2017 · 5 comments
Labels
closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix enhancement new capability or improved behavior of existing capability

Comments

@billsacks
Copy link
Member

Bill Sacks < [email protected] > - 2013-04-13 05:16:34 -0600
Bugzilla Id: 1662
Bugzilla CC: [email protected], [email protected], [email protected], [email protected], [email protected],

Recently, the 360x720 resolution was renamed to 360x720cru. However, the directory in inputdata/lnd/clm2/mappingdata/maps is still named 360x720. This (a) could cause confusion, and more importantly (b) messes up the tools we have to post-process files created by mkmapdata (automatically creating xml entries and moving files into the correct location).

I'm not sure what the correct solution is:

(1) Live with it? It seems like we'll always be tripping up on this, having to correct the automated mkmapdata post-processing scripts.

(2) Fix the mkmapdata post-processing tools so they give special handling to this grid?

(3) Rename the mapping directory in inputdata? But that will break any older tags.

(4) Rename the mapping directory in inputdata, and make a sym link in yellowstone's inputdata (360x720 -> 360x720cru) so that old tags will at least continue to work there. This is probably my preference.

Note that a renaming of the inputdata directory will require (a) changing paths in the namelist defaults files, and (b) require running some CESM tests and tools tests at 360x720cru resolution, to make sure all necessary paths have been changed correctly. These tests should be done BEFORE making the sym link suggested in (4).

Because this might be a pain, I think it can wait until after the release.

@billsacks billsacks added this to the clm5 milestone Dec 16, 2017
@billsacks
Copy link
Member Author

Erik Kluzek < [email protected] > - 2013-04-13 09:08:57 -0600

Hi Bill

I propose another solution entirely, that isn't too hard.

Create a new directory called 360x720cru, and put a copy of the mapping files in there. In svn you can do this with "svn copy" so the repo. doesn't increase in size. On disk we'll have both copies around, but that's OK. This means there is no special handling for this grid, and we just have dual copies of the directory on disk. We need the old version around because of previous versions of the model, and the new for ones going forward.

So

inputdata/lnd/clm2/mappingdata/maps/360x720 -- will continue to exist for old tags

inputdata/lnd/clm2/mappingdata/maps/360x720cru -- will exist for new tags going forward.

@billsacks
Copy link
Member Author

Bill Sacks < [email protected] > - 2013-04-13 13:53:02 -0600

I agree with Erik's solution.

However, in the interest in getting my tools tag made this weekend -- and in the interest of not having this work take over my weekend -- I am not going to make this change as part of this tag. I'm worried that, what seems simple on the surface will actually take some time to get right. To test it properly, I think we should first rename (NOT copy) the inputdata directory and make all necessary changes in the xml files, then run the full test suite to make sure everything necessary has been changed in the xml files, then finally do the copy for the sake of old tags.

My feeling is that this isn't critical to fix immediately, because everything works as is right now. It will only become a problem when we are adding new standard mapping files.

Thus I propose that this be deferred until after the release freeze.

@billsacks
Copy link
Member Author

Mariana Vertenstein < [email protected] > - 2013-04-13 20:15:28 -0600

Bill - I agree with your proposal. The key point is to make the release freeze. I had run over this issue with Erik before I checked this in - and it seemed okay. We can sort this all out later - as long as it is working now.

@billsacks
Copy link
Member Author

Bill Sacks < [email protected] > - 2013-12-17 11:16:21 -0700

Un-assigning myself from this... I was only assigned to this because it came up in the course of my work a few months ago, but it's not currently relevant for me.

billsacks added a commit that referenced this issue Jan 30, 2018
Lnd-atm coupling fixes

Added atmosphere model's surface height as a required input, and 10-m
wind speed as an output.

Also fixed some typos.
@billsacks billsacks added the enhancement new capability or improved behavior of existing capability label Feb 8, 2018
@billsacks billsacks removed this from the clm5 milestone Nov 7, 2018
mariuslam pushed a commit to NordicESMhub/ctsm that referenced this issue Aug 26, 2019
billsacks pushed a commit to billsacks/ctsm that referenced this issue Nov 15, 2019
Pack environmental inputs into a derived type
@ekluzek ekluzek mentioned this issue Mar 12, 2020
billsacks added a commit to billsacks/ctsm that referenced this issue Mar 27, 2020
Lnd-atm coupling fixes

Added atmosphere model's surface height as a required input, and 10-m
wind speed as an output.

Also fixed some typos.
slevis-lmwg referenced this issue in slevis-lmwg/ctsm Aug 1, 2023
Fix some issues with nag compiler
slevis-lmwg referenced this issue in slevis-lmwg/ctsm Aug 1, 2023
…rather than a divide that goes to real in python3
slevis-lmwg referenced this issue in slevis-lmwg/ctsm Aug 1, 2023
Changes to fix #10, where an integer divide needs the floor operator
samsrabin referenced this issue in samsrabin/CTSM Apr 19, 2024
fix for fldptr return mode
samsrabin referenced this issue in samsrabin/CTSM Apr 19, 2024
@ekluzek ekluzek added the closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix label Apr 30, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Apr 30, 2024

This is no longer an issue in the latest CTSM especially with ctsm5.2.0. Closing as wontfix, but it's no longer a problem either so doesn't matter.

@ekluzek ekluzek closed this as completed Apr 30, 2024
AGonzalezNicolas pushed a commit to HPSCTerrSys/clm5_0 that referenced this issue Jun 27, 2024
Commit summary:
* 71baab0 Fixed wrong domain decomposition by switching to ORANGE partitioning scheme
* 6a0fce3 Fixed syntax for checking missing dict keys
* 1bea6fd Changed to bundled coupling fields (w/ extra dim = # of soil levels)
* fb6b252 Always compile with OpenMP.
* 906ff7b Fixed mismatched coupling timestep with ParFlow
AGonzalezNicolas added a commit to HPSCTerrSys/clm5_0 that referenced this issue Jun 27, 2024
…643f4822ca3f4265302ef26e7a50bfc2dc5e2' into eclm
gdicker1 added a commit to gdicker1/CTSM that referenced this issue Aug 30, 2024
…OMP#10)

Revert a bad merge commit from upstream and incorporate changes from
upstream tag 'ctsm5.2.005'
ekluzek added a commit to ekluzek/CTSM that referenced this issue Sep 12, 2024
Update surface datasets in namelist defaults
samsrabin referenced this issue in samsrabin/CTSM Sep 17, 2024
protections metadata on eca phosphatase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed: wontfix We won't fix this issue, because it would be too difficult and/or isn't important enough to fix enhancement new capability or improved behavior of existing capability
Projects
None yet
Development

No branches or pull requests

2 participants