Merge remote-tracking branch 'slevisconsulting/gcell_bal_checks_h2o'

Grid cell-level error check for H2O

For more robust mass balance error checking, introduced
grid cell-level error check for H2O following the approach
of pull requests #984 and #1022

Resolves #201 (Perform gridcell-level water balance checks
bracketing the entire run loop)

doc/ChangeLog

@@ -1,4 +1,121 @@
 ===============================================================
+Tag name:  ctsm5.1.dev024
+Originator(s):  slevis (Samuel Levis,303-665-1310)
+Date:  Sat Feb 20 14:42:33 MST 2021
+One-line Summary: Grid cell-level error check for H2O
+
+Purpose of changes
+------------------
+
+ For more robust mass balance error checking, introduced
+ grid cell-level error check for H2O following the approach
+ of pull requests #984 and #1022
+
+
+Bugs fixed or introduced
+------------------------
+
+Issues fixed (include CTSM Issue #): #201
+
+
+Significant changes to scientifically-supported configurations
+--------------------------------------------------------------
+
+Does this tag change answers significantly for any of the following physics configurations?
+(Details of any changes will be given in the "Answer changes" section below.)
+
+    [Put an [X] in the box for any configuration with significant answer changes.]
+
+[ ] clm5_1
+
+[ ] clm5_0
+
+[ ] ctsm5_0-nwp
+
+[ ] clm4_5
+
+Notes of particular relevance for users
+---------------------------------------
+
+Caveats for users (e.g., need to interpolate initial conditions):
+ None
+
+Changes to CTSM's user interface (e.g., new/renamed XML or namelist variables):
+ None
+
+Changes made to namelist defaults (e.g., changed parameter values):
+ None
+
+Changes to the datasets (e.g., parameter, surface or initial files):
+ None
+
+Substantial timing or memory changes: [For timing changes, can check PFS test(s) in the test suite]
+ None
+
+Notes of particular relevance for developers: (including Code reviews and testing)
+---------------------------------------------
+NOTE: Be sure to review the steps in README.CHECKLIST.master_tags as well as the coding style in the Developers Guide
+
+Caveats for developers (e.g., code that is duplicated that requires double maintenance):
+ None
+
+Changes to tests or testing:
+ None
+
+CTSM testing:
+
+ [PASS means all tests PASS and OK means tests PASS other than expected fails.]
+
+  build-namelist tests:
+
+    cheyenne - 
+
+  tools-tests (test/tools):
+
+    cheyenne - 
+
+  PTCLM testing (tools/shared/PTCLM/test):
+
+    cheyenne - 
+
+  python testing (see instructions in python/README.md; document testing done):
+
+    (any machine) - 
+
+  regular tests (aux_clm):
+
+    cheyenne ---- OK (comparisons to baseline fail as expected)
+    izumi ------- OK (comparisons to baseline fail as expected)
+
+If the tag used for baseline comparisons was NOT the previous tag, note that here:
+
+
+Answer changes
+--------------
+
+Changes answers relative to baseline: YES
+
+  Summarize any changes to answers, i.e.,
+    - what code configurations: ALL
+    - what platforms/compilers: ALL
+    - nature of change: ROUNDOFF
+
+ Explanation: Moving call BalanceCheck to after the call lnd2glc in
+ subroutine clm_drv causes a change in order of operations that leads to
+ roundoff change in ERRH2O. Confirmed by running ./summarize_cprnc_diffs
+
+
+Detailed list of changes
+------------------------
+
+List any externals directories updated (cime, rtm, mosart, cism, fates, etc.):
+ None
+
+Pull Requests that document the changes (include PR ids):
+ https://github.com/ESCOMP/ctsm/pull/1228
+
+===============================================================
+===============================================================
 Tag name:  ctsm5.1.dev023
 Originator(s):  erik (Erik Kluzek,UCAR/TSS,303-497-1326)
 Date: Thu Feb 11 00:14:03 MST 2021

doc/ChangeSum

@@ -1,5 +1,6 @@
 Tag                   Who      Date  Summary
 ============================================================================================================================
+  ctsm5.1.dev024   slevis 02/20/2021 Grid cell-level error check for H2O
   ctsm5.1.dev023     erik 02/11/2021 Calculate leaf biomass for non-woody PFTS, and a few other small answer changes
   ctsm5.1.dev022 glemieux 02/05/2021 Merge fates_main_api into ctsm master
   ctsm5.1.dev021     erik 01/12/2021 Add option for biomass heat storage (BHS) to clm5_1 physics